From 88f89938578026a8bb73c3f3958af09bfa29ad31 Mon Sep 17 00:00:00 2001 From: Scott Cooper Date: Tue, 7 Apr 2026 15:48:54 -0700 Subject: [PATCH] fix(issues): Always show loading toast for bulk actions The loading indicator was gated behind `itemIds?.length` which meant "select all in query" operations (where itemIds is undefined) had no feedback. Also swaps the silent `clearIndicators()` on success for an explicit success toast so users get confirmation. Co-Authored-By: Claude Opus 4.6 --- static/app/views/issueList/actions/index.tsx | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/static/app/views/issueList/actions/index.tsx b/static/app/views/issueList/actions/index.tsx index 3affc33c3d4ca0..89221a78531ce3 100644 --- a/static/app/views/issueList/actions/index.tsx +++ b/static/app/views/issueList/actions/index.tsx @@ -11,7 +11,7 @@ import {bulkDelete, bulkUpdate, mergeGroups} from 'sentry/actionCreators/group'; import { addErrorMessage, addLoadingMessage, - clearIndicators, + addSuccessMessage, } from 'sentry/actionCreators/indicator'; import {IssueStreamHeaderLabel} from 'sentry/components/IssueStreamHeaderLabel'; import {Sticky} from 'sentry/components/sticky'; @@ -305,9 +305,7 @@ export function IssueListActions({ // * users with global views need to be explicit about what projects the query will run against const projectConstraints = {project: getSelectedProjectIds(itemIds)}; - if (itemIds?.length) { - addLoadingMessage(t('Saving changes\u2026')); - } + addLoadingMessage(t('Saving changes\u2026')); bulkUpdate( api, @@ -323,7 +321,7 @@ export function IssueListActions({ }, { success: () => { - clearIndicators(); + addSuccessMessage(t('Changes saved')); onActionTaken?.(itemIds ?? [], data); // Prevents stale data on issue details @@ -346,7 +344,6 @@ export function IssueListActions({ } }, error: () => { - clearIndicators(); addErrorMessage(t('Unable to update issues')); }, }