ref(transactions): Remove all of transaction metric extraction#5792
Merged
ref(transactions): Remove all of transaction metric extraction#5792
Conversation
Dav1dde
force-pushed
the
dav1d/rm-transaction-metric-extraction
branch
from
b134b65 to
52ddb1d
Compare
loewenheim
approved these changes
Apr 8, 2026
Dav1dde
force-pushed
the
dav1d/rm-transaction-metric-extraction
branch
from
52ddb1d to
ed909ef
Compare
Dav1dde
force-pushed
the
dav1d/rm-transaction-metric-extraction
branch
from
ed909ef to
b046034
Compare
Member
Author
|
@loewenheim jfyi the scope changed a bit sicne you last reviewed. I also deleted the metric namespace and had to adjust a bunch more tests. |
jjbayer
reviewed
Apr 9, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2a7d31e. Configure here.
jjbayer
approved these changes
Apr 9, 2026
loewenheim
reviewed
Apr 9, 2026
This was referenced Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This showcases a problem (which existed before) where we attach the transaction outcome to the span usage metric. When there are span rate limits, the transaction is also not counted. The code comment addresses a few options.