chore: Add new file and add argument for consistency

Author: calvin-codecov

codecov-cli/codecov_cli/helpers/upload_url_validation.py

@@ -0,0 +1,54 @@
+import typing
+from urllib.parse import urlparse
+
+import click
+
+from codecov_cli.helpers.config import CODECOV_INGEST_URL
+from codecov_cli.helpers.git import GitService
+
+# The set of acceptable upload services from Shelter
+_CODECOV_UPLOAD_SERVICES = frozenset(s.value for s in GitService) | {"github-actions"}
+
+
+def validate_upload_url_base_parts(
+    upload_url: str,
+    service: str,
+    slug: typing.Optional[str],
+    default_base_url_for_error: str = CODECOV_INGEST_URL,
+) -> None:
+    parsed = urlparse(upload_url)
+    if parsed.scheme not in ("http", "https") or not parsed.netloc:
+        raise click.ClickException(
+            f"Invalid Codecov base URL {upload_url!r}. Use an absolute http(s) URL with a host "
+            f"(default: {default_base_url_for_error})."
+        )
+    if not slug or not str(slug).strip():
+        raise click.ClickException(
+            "Repository slug is missing or empty. Pass -r / --slug owner/repo (or set SLUG)."
+        )
+    if not service:
+        allowed = ", ".join(sorted(_CODECOV_UPLOAD_SERVICES))
+        raise click.ClickException(
+            "Upload service is missing (Codecov requires it for upload URLs). "
+            f"Pass --git-service with one of: {allowed}"
+        )
+    if service not in _CODECOV_UPLOAD_SERVICES:
+        allowed = ", ".join(sorted(_CODECOV_UPLOAD_SERVICES))
+        raise click.ClickException(
+            f"Invalid upload service {service!r}. Use one of: {allowed}"
+        )
+
+
+def validate_url_commit_sha(commit_sha: typing.Optional[str]) -> None:
+    if commit_sha is None or not str(commit_sha).strip():
+        raise click.ClickException(
+            "Commit SHA is missing or empty. Pass -C / --sha / --commit-sha."
+        )
+
+# This function includes validate_commit_sha check
+def validate_url_report_path_segments(commit_sha: typing.Optional[str], report_code: typing.Optional[str]) -> None:
+    validate_url_commit_sha(commit_sha)
+    if report_code is None or not str(report_code).strip():
+        raise click.ClickException(
+            "Report code is missing or empty. Pass --code / --report-code."
+        )

codecov-cli/codecov_cli/services/report/__init__.py

@@ -66,7 +66,7 @@ def send_create_report_request(
     headers = get_token_header(token)
     upload_url = enterprise_url or CODECOV_INGEST_URL
     service_part = (service or "").strip()
-    validate_upload_url_base_parts(upload_url, service_part, encoded_slug)
+    validate_upload_url_base_parts(upload_url, service_part, encoded_slug, CODECOV_INGEST_URL)
     validate_url_report_path_segments(commit_sha, code)
     url = f"{upload_url.rstrip('/')}/upload/{service_part}/{encoded_slug}/commits/{commit_sha}/reports"
     return send_post_request(url=url, headers=headers, data=data)