feat(testing): Support reusable prepared test artifacts#475
Open
cameroncooke wants to merge 11 commits into
Open
feat(testing): Support reusable prepared test artifacts#475cameroncooke wants to merge 11 commits into
cameroncooke wants to merge 11 commits into
Conversation
commit: |
cameroncooke
marked this pull request as ready for review
July 16, 2026 16:19
Keep source-only xcodebuild arguments out of the generated test-without-building phase and sort final test failures independently of emission order.
Share per-test environment setup and cleanup across snapshot suites, cache suite-level simulator builds, and normalize volatile output so fixtures remain stable. Update non-environmental fixtures and add coverage for cleanup and normalization behavior.
Prevent session defaults and selectors from leaking into prepared test runs, remove a useless simulator state initializer, and align volatile snapshot fixtures across CLI and MCP.
Keep only-testing and skip-testing arguments in the prepared test phase while retaining session-default conflict filtering.
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ae6d5ba. Configure here.
| platform, | ||
| logPrefix: `${platform} Device Build`, | ||
| logPrefix: `${platform} Device ${resolved.logLabel}`, | ||
| deviceId: params.buildForTesting ? params.deviceId : undefined, |
Contributor
There was a problem hiding this comment.
Session device blocks generic builds
Medium Severity
Adding deviceId to the build_device schema makes session deviceId merge into every buildForTesting call. A session device then forces a device-specific destination, so the supported generic build-for-testing path becomes unreachable without clearing session defaults, and portable products can be built for the wrong device.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit ae6d5ba. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Why
Agents and CI workflows need to prepare tests once and execute them later without falling back to raw
xcodebuild. The existing build tools always finished with a normal build action, so they could not expose the reusable products produced bybuild-for-testing.What Changed
buildForTestingand optionaltestProductsPathinputs..xctestproductsbundles and discovered.xctestrunfiles as structured build artifacts..xctestproductsbundles or advanced.xctestruninputs without rebuilding, while returning the new.xcresultproduced by the run.Fixes #450