ciel 3.0.0 with ihp-sg13cmos5l - #140
Open
donn wants to merge 7 commits into
Open
Conversation
- (breaking) rename family to ihp-sg13 and update ihp build scripts accordingly - fix copyrights on various files - update ci
All of these are breaking changes btw: - outputs to non-ttys are now plain-text instead of JSON - Family.default_includes is now a dictionary of patterns to lists, where the patterns are to be matched against a variant to determine the default library set that should be built/pulled - Families now auto-register to both by_name and a new by_variant class dictionaries - Family.resolve_libraries now requires a new argument, variant - enable, fetch, push, and build now take a (pdk_family, pdk_variant) tuple instead of just the PDK family - enable and fetch no longer support automatic pushing - get_ciel_home now returns a pathlib.Path, and so does Version.get_dir - resolve_pdk_family's argument is no longer optional, moved to family.py, added to top-level exports - resolve_pdk_variant moved to families.py, added to top-level exports - remove deprecated method `get()`
donn
marked this pull request as draft
August 27, 2026 13:07
donn
force-pushed
the
donn/ihp-sg13cmos5l
branch
from
August 27, 2026 13:10
aa9f431 to
d4ea7c8
Compare
adds new variant to ihp-sg13, three new libraries, and a new default include set if installation for that specific variant is requested
donn
force-pushed
the
donn/ihp-sg13cmos5l
branch
2 times, most recently
from
August 27, 2026 22:54
be6d03d to
f1c8c78
Compare
donn
force-pushed
the
donn/ihp-sg13cmos5l
branch
from
August 27, 2026 23:00
f1c8c78 to
9625178
Compare
mole99
approved these changes
Sep 1, 2026
mole99
left a comment
mole99
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me!
The pdk-family/pdk-variant tuple makes things much less ambiguous.
donn
commented
Sep 1, 2026
donn
marked this pull request as ready for review
September 7, 2026 17:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
against a variant to determine the default library set that should be built/pulled
get(), has been removedghmodulemainandpull_requeststo save compute