fix: return error immediately on failed reconciliation status

Aman-Cool · matheuscscp · Aman-Cool · commit 0a29617f4652 · 2026-01-26T22:37:56.000+05:30
Co-authored-by: Matheus Pimenta &lt;matheuscscp@gmail.com&gt;
Signed-off-by: Aman-Cool &lt;aman017102007@gmail.com&gt;
diff --git a/cmd/flux/reconcile.go b/cmd/flux/reconcile.go
@@ -152,7 +152,14 @@ func reconciliationHandled(kubeClient client.Client, namespacedName types.Namesp
 			return false, err
 		}
 
-		return result.Status == kstatus.CurrentStatus, nil
+		switch result.Status {
+		case kstatus.CurrentStatus:
+			return true, nil
+		case kstatus.InProgressStatus:
+			return false, nil
+		default:
+			return false, fmt.Errorf("%s", result.Message)
+		}
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,14 @@ func reconciliationHandled(kubeClient client.Client, namespacedName types.Namesp`
`152`	`152`	`return false, err`
`153`	`153`	`}`
`154`	`154`
`155`		`- return result.Status == kstatus.CurrentStatus, nil`
	`155`	`+ switch result.Status {`
	`156`	`+ case kstatus.CurrentStatus:`
	`157`	`+ return true, nil`
	`158`	`+ case kstatus.InProgressStatus:`
	`159`	`+ return false, nil`
	`160`	`+ default:`
	`161`	`+ return false, fmt.Errorf("%s", result.Message)`
	`162`	`+ }`
`156`	`163`	`}`
`157`	`164`	`}`
`158`	`165`