Repository navigation
fix(fleetops): repair three broken variable chains - #31
Merged
Merged
Conversation
roncodes
force-pushed
the
fix/fleetops-captures-and-contact-type
branch
from
August 11, 2026 10:57
9075742 to
6dd1379
Compare
Retrieve an Order Config set {{order_config_id}} in its OWN afterResponse.
That cannot work — the value has to exist before the request is sent, so the
URL went out as /order-configs/%7B%7Border_config_id%7D%7D and answered "Order
config not found." Query Order Configs runs first and is the natural source, so
it captures the id now.
Render Label addressed {{label_subject_id}}, which nothing set.
It answered "Unable to render label." for the literal placeholder. The request
already pins type=order, so it renders {{order_id}} — a label for the order the
collection just created.
Update a Contact tried to change a customer contact's type.
Create a Contact makes one with "type": "customer", and the update sent
"type": "technician". The API refuses that deliberately —
"Customer contact type cannot be changed." — because the contact is linked to a
customer record. The example was documenting an operation the API does not allow.
`type` is dropped rather than the create being changed: updating a contact's
name, title, email and phone is the real use case, and a customer contact whose
type is immutable is the behaviour worth showing.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
roncodes
force-pushed
the
fix/fleetops-captures-and-contact-type
branch
from
August 11, 2026 10:59
6dd1379 to
af0cb02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three more failures from the contract run, all in the collection rather than the API.
Retrieve an Order Configset its own idIt captured
{{order_config_id}}in its ownafterResponse— which cannot work, because the value has to exist before the request is sent. The URL went out as/order-configs/%7B%7Border_config_id%7D%7Dand answered "Order config not found."Query Order Configsruns first and is the natural source, so it captures the id now.Render Labeladdressed a variable nothing set{{label_subject_id}}had no source anywhere, so the request rendered the literal placeholder and answered "Unable to render label." The request already pinstype=order, so it now renders{{order_id}}— a label for the order the collection just created.Update a Contactdocumented an operation the API forbidsCreate a Contactmakes a contact with"type": "customer", and the update sent"type": "technician". The API refuses that deliberately — "Customer contact type cannot be changed." — because the contact is linked to a customer record.typeis dropped from the update rather than changing whatCreate a Contactmakes: updating name, title, email and phone is the real use case, and a customer contact whose type is immutable is the behaviour worth documenting.Related
Delete a Zone's 404 turned out not to be a collection or API problem at all — the contract runner defers deletes and was removing the parent service area first. Fixed in fleetbase/fleetbase#598.🤖 Generated with Claude Code