Generate test code by AI agents

Prompt:
DB 스키마에서 `instance` 를 Local/Remote 로 분리하고 API 를 수정하면서 기존 스키마/API 에 맞춰놨던 일부 테스트가 문제 되고 있습니다. [instance.test.ts](packages/graphql/src/instance.test.ts) 파일의 20419ce 커밋 변경 사항을 참고해서 문제되는 파일들의 코드를 직접 수정하세요. 문제되는 파일들은 `mise check`, `mise test` 로 찾을 수 있습니다.
추가적으로 리모트 인스턴스를 위한 테스트도 추가하세요. 너무 복잡한 테스트 말고, 생성, host 유일성 체크 정도만 추가하세요.

Assisted-by: Codex:gpt-5-6-sol

Author: 2chanhaeng

packages/graphql/src/account.test.ts

@@ -52,7 +52,8 @@ const accountInstancesQuery = `
           admin
           node {
             uuid
-            slug
+            location
+            host
           }
         }
       }
@@ -82,7 +83,8 @@ const accountInstancesResponse = {
             admin: true,
             node: {
               uuid: acceptedInstanceId,
-              slug: "test-instance",
+              location: "Local",
+              host: "test-instance.drfed.org",
             },
           },
         ],
@@ -148,20 +150,7 @@ async function seedAccounts(db: Database): Promise<void> {
 
 async function seedMembershipGraph(db: Database): Promise<void> {
   await seedAccounts(db);
-  await db.insert(schema.instances).values([
-    {
-      id: acceptedInstanceId,
-      slug: "test-instance",
-      created,
-      expires,
-    },
-    {
-      id: pendingInstanceId,
-      slug: "pending-instance",
-      created,
-      expires,
-    },
-  ]);
+  await seedLocalInstances(db);
   await db.insert(schema.instanceMembers).values([
     {
       accountId,
@@ -193,3 +182,30 @@ async function seedMembershipGraph(db: Database): Promise<void> {
     },
   ]);
 }
+
+async function seedLocalInstances(db: Database): Promise<void> {
+  await db.insert(schema.instances).values([
+    {
+      id: acceptedInstanceId,
+      location: "Local",
+      created,
+    },
+    {
+      id: pendingInstanceId,
+      location: "Local",
+      created,
+    },
+  ]);
+  await db.insert(schema.localInstances).values([
+    {
+      id: acceptedInstanceId,
+      slug: "test-instance",
+      expires,
+    },
+    {
+      id: pendingInstanceId,
+      slug: "pending-instance",
+      expires,
+    },
+  ]);
+}

packages/graphql/src/builder.ts

@@ -15,7 +15,7 @@
 // along with this program.  If not, see <https://www.gnu.org/licenses/>.
 
 import { type Database, normalizeEmail, relations } from "@drfed/models";
-import type { Account, Session, Location } from "@drfed/models/schema";
+import type { Account, Session } from "@drfed/models/schema";
 import { Template } from "@fedify/uri-template";
 import SchemaBuilder, { type ObjectRef } from "@pothos/core";
 import DrizzlePlugin from "@pothos/plugin-drizzle";
@@ -90,10 +90,6 @@ export interface SchemaTypes {
       Input: string;
       Output: string;
     };
-    Location: {
-      Input: Location;
-      Output: Location;
-    };
     UUID: {
       Input: string;
       Output: string;

packages/graphql/src/instance.test.ts

@@ -19,6 +19,7 @@ import assert from "node:assert/strict";
 
 import { type Database, schema } from "@drfed/models";
 import { describe, it } from "@logtape/testing-node/autoload";
+import { DrizzleQueryError } from "drizzle-orm";
 
 import { withTestHarness } from "./harness.test.ts";
 
@@ -31,9 +32,26 @@ const accountId = "00000000-0000-4000-8000-000000000001";
 const memberId = "00000000-0000-4000-8000-000000000002";
 const pendingMemberId = "00000000-0000-4000-8000-000000000003";
 const instanceId = "00000000-0000-4000-8000-000000000101";
+const duplicateRemoteInstanceId = "00000000-0000-4000-8000-000000000102";
 const sessionId = "00000000-0000-4000-8000-000000000201";
 const accessToken = "test-access-token";
 
+const remoteInstanceQuery = `
+  query RemoteInstance($uuid: UUID!) {
+    accountByUuid(uuid: $uuid) {
+      instances {
+        edges {
+          node {
+            uuid
+            location
+            host
+          }
+        }
+      }
+    }
+  }
+`;
+
 const instanceMembersQuery = `
   query InstanceMembers($uuid: UUID!) {
     accountByUuid(uuid: $uuid) {
@@ -122,7 +140,8 @@ const createInstanceMutation = `
       __typename
       ... on Instance {
         uuid
-        slug
+        location
+        host
       }
       ... on CreateInstanceError {
         type
@@ -146,15 +165,16 @@ describe("Mutation.createInstance", () => {
       const body = await response.json();
       assert.equal(body.errors, undefined);
       assert.equal(body.data.createInstance.__typename, "Instance");
-      assert.equal(body.data.createInstance.slug, "my-instance");
+      assert.equal(body.data.createInstance.location, "Local");
+      assert.equal(body.data.createInstance.host, "my-instance.drfed.org");
       assert.equal(typeof body.data.createInstance.uuid, "string");
 
       const instances = await db.select().from(schema.instances);
       assert.equal(instances.length, 1);
       const instance = instances[0]!;
       assert.equal(instance.location, "Local");
       const local = await db.query.localInstances.findFirst({
-        where: instance,
+        where: { id: instance.id },
       });
       assert.equal(local?.slug, "my-instance");
 
@@ -231,6 +251,61 @@ describe("Mutation.createInstance", () => {
   });
 });
 
+describe("Remote instance", () => {
+  it("returns a created remote instance", async () => {
+    await withTestHarness(async ({ db, post }) => {
+      await seedRemoteInstance(db);
+
+      const response = await post({
+        query: remoteInstanceQuery,
+        variables: { uuid: accountId },
+      });
+
+      assert.equal(response.status, ok);
+      assert.deepEqual(await response.json(), {
+        data: {
+          accountByUuid: {
+            instances: {
+              edges: [
+                {
+                  node: {
+                    uuid: instanceId,
+                    location: "Remote",
+                    host: "remote.example.com",
+                  },
+                },
+              ],
+            },
+          },
+        },
+      });
+    });
+  });
+
+  it("requires a unique host", async () => {
+    await withTestHarness(async ({ db }) => {
+      await seedRemoteInstance(db);
+      await db.insert(schema.instances).values({
+        id: duplicateRemoteInstanceId,
+        location: "Remote",
+        created,
+      });
+
+      await assert.rejects(
+        db.insert(schema.remoteInstances).values({
+          id: duplicateRemoteInstanceId,
+          host: "remote.example.com",
+        }),
+        (error: unknown) =>
+          error instanceof DrizzleQueryError &&
+          error.cause != null &&
+          "constraint" in error.cause &&
+          error.cause.constraint === "remote_instances_host_key",
+      );
+    });
+  });
+});
+
 /**
  * Seeds an account and an authenticated session, then returns the request
  * options carrying the session's bearer token.
@@ -331,3 +406,27 @@ async function seedInstanceMembers(db: Database): Promise<void> {
     },
   ]);
 }
+
+async function seedRemoteInstance(db: Database): Promise<void> {
+  await db.insert(schema.accounts).values({
+    id: accountId,
+    email: "owner@example.com",
+    name: "Owner",
+    created,
+  });
+  await db.insert(schema.instances).values({
+    id: instanceId,
+    location: "Remote",
+    created,
+  });
+  await db.insert(schema.remoteInstances).values({
+    id: instanceId,
+    host: "remote.example.com",
+  });
+  await db.insert(schema.instanceMembers).values({
+    accountId,
+    instanceId,
+    accepted,
+    created,
+  });
+}

packages/graphql/src/instance.ts

@@ -16,7 +16,7 @@
 
 // oxlint-disable max-lines-per-function
 import { schema } from "@drfed/models";
-import { instanceMembers } from "@drfed/models/schema";
+import { instanceMembers, locationEnum } from "@drfed/models/schema";
 import { drizzleConnectionHelpers } from "@pothos/plugin-drizzle";
 import { DrizzleQueryError } from "drizzle-orm";
 import { and, eq, isNotNull } from "drizzle-orm/sql/expressions";
@@ -26,6 +26,10 @@ import { v7 as uuid } from "uuid";
 import { Account } from "./account.ts";
 import builder, { type DrFedObjectRef } from "./builder.ts";
 
+const Location = builder.enumType("Location", {
+  values: locationEnum.enumValues,
+});
+
 const InstanceRef = builder.drizzleNode("instances", {
   name: "Instance",
   description: "Represents an `Instance` in the DrFed platform.",
@@ -41,7 +45,7 @@ const InstanceRef = builder.drizzleNode("instances", {
       description: "The UUID of the `Instance`.",
     }),
     location: t.expose("location", {
-      type: "Location",
+      type: Location,
       description: 'The location of the `Instance`: "Local" | "Remote"',
     }),
     host: t.string({
@@ -258,7 +262,7 @@ builder.mutationFields((t) => ({
             tooManyInstances = true;
             tx.rollback();
           }
-          tx.insert(schema.localInstances).values({
+          await tx.insert(schema.localInstances).values({
             id,
             slug,
             expires: new Date(
@@ -278,7 +282,7 @@ builder.mutationFields((t) => ({
           e instanceof DrizzleQueryError &&
           e.cause != null &&
           "constraint" in e.cause &&
-          e.cause.constraint === "instances_slug_key"
+          e.cause.constraint === "local_instances_slug_key"
         ) {
           return {
             message: `The slug ${JSON.stringify(slug)} is already taken.`,