chore(deps): migrate to famedly-zitadel-rust-client v0.12 - #164
Conversation
nikzen
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #164 +/- ##
==========================================
+ Coverage 91.02% 93.90% +2.88%
==========================================
Files 10 10
Lines 1604 1657 +53
==========================================
+ Hits 1460 1556 +96
+ Misses 144 101 -43
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
|
sirewix
left a comment
sirewix
left a comment
There was a problem hiding this comment.
Looks ok on the surface, but there are so many changes in test code. If we want to verify everything it will take a lot of time
| @@ -1,5 +1,7 @@ | |||
| //! E2E tests for the id installation script | |||
|
|
|||
| #![cfg(test)] | |||
There was a problem hiding this comment.
| #![cfg(test)] |
There was a problem hiding this comment.
Keeping #![cfg(test)]: without it the pinned-nightly clippy run (cargo clippy --workspace --all-targets -- -D warnings) fails this target with four clippy::expect_used errors, because the crate-level lint config in Cargo.toml warns on expect_used and CI runs with -D warnings. The attribute keeps the whole file out of the non-test compilation of the test target (the same pattern is already used in tests/e2e.rs and tests/common/mod.rs).
nikzen
changed the title
6c1a44a to
21fc327
Compare
nikzen
changed the title
- Depend on famedly-zitadel-rust-client from crates.io instead of the git
repository
- Drop the security-advisory claim from the changelog, as the legacy v1
client was only used in tests
- Match error codes with {error:?} instead of {error:#}
- Depend on famedly-zitadel-rust-client from crates.io instead of the git
repository
- Drop the security-advisory claim from the changelog, as the legacy v1
client was only used in tests
- Match error codes with {error:?} instead of {error:#}
30d2951 to
6ee42a8
Compare
Replace the legacy zitadel-rust-client v0.3 (gRPC v1 API) with famedly-zitadel-rust-client v0.12 (v2 HTTP API) from crates.io: - Resolve the remaining security advisories on the old dependency line - Match Zitadel error codes across the full v2 error chain, restoring the "user already exists" update path and the invalid-phone fallback - Migrate the e2e suite from the gRPC v1 client to the v2 HTTP API - Merge main (UKT no-users fix, v0.11.3 release) - Address PR #164 review comments (crates.io dependency, changelog, {error:?} error matching) - Fix formatting and an ldap3 drive! macro lint for the new CI nightly (nightly-2026-09-07)
6ee42a8 to
0eb029c
Compare
2 participants
Summary
Migrates the Zitadel client dependency from famedly-zitadel-rust-client v0.3.0 to v0.12 (currently pinned to
0.12.2inCargo.lock), dropping the legacy v1 API feature. This resolves the remaining security advisories on the old dependency line.Client version status
Cargo.tomlrequiresversion = "0.12";Cargo.lockresolves to v0.12.2 (commit2feabec).reqwest_middleware-based client constructor, new update method,create_invite_code), but is intentionally not part of this migration.create_human_user,add_user_grant,set_user_metadata,search_user_grants,list_users,Token) are unchanged between v0.12.2 and v0.13.1; v0.13'screate_invite_codeis not yet adopted here — the follow-up fix (fix: Send first-login invitations to provisioned users (FP-295) #166) ships its own raw-HTTP invitation extension, which can migrate to the native method in a later dependency bump.What changed
(deps)Migrate to famedly-zitadel-rust-client v0.12, drop the v1 featureMerge notes
GitHub currently reports this PR as
CONFLICTING/DIRTYwithmain, but the conflicts are confined to version-marker lines:CHANGELOG.md— main gained the0.11.3entry; branch carries0.12.0on top of0.11.2Cargo.toml/Cargo.lock—version = "0.11.3"vs0.12.0and the dependency lines abovesrc/lib.rsauto-merges; the UKT no-users fix (#65c0759) and the newimport_source_userhelper touch disjoint regionsResolution direction: keep the branch's
0.12.0version and v0.12 dependency, keep main's0.11.3entry above0.12.0in the changelog (or reorder by date), take main's UKT change inCargo.lock.