fix: ensure range requests in txn are executed on all cluster members

Fix data inconsistency issue #18667 where specifying a revision
for a range request in a transaction may cause data inconsistency
across cluster members.

The removeNeedlessRangeReqs function was incorrectly removing
range requests from txn operations on some cluster members,
causing write operations to be executed on some members while
failing on others.

Author: kairosci

server/etcdserver/apply/apply.go

@@ -39,9 +39,6 @@ func Apply(lg *zap.Logger, e *raftpb.Entry, uberApply UberApplier, w wait.Wait,
 
 	needResult := w.IsRegistered(id)
 	if needResult || !noSideEffect(&raftReq) {
-		if !needResult && raftReq.Txn != nil {
-			removeNeedlessRangeReqs(raftReq.Txn)
-		}
 		return uberApply.Apply(&raftReq, shouldApplyV3), id
 	}
 	return nil, id
@@ -50,21 +47,3 @@ func Apply(lg *zap.Logger, e *raftpb.Entry, uberApply UberApplier, w wait.Wait,
 func noSideEffect(r *pb.InternalRaftRequest) bool {
 	return r.Range != nil || r.AuthUserGet != nil || r.AuthRoleGet != nil || r.AuthStatus != nil
 }
-
-func removeNeedlessRangeReqs(txn *pb.TxnRequest) {
-	f := func(ops []*pb.RequestOp) []*pb.RequestOp {
-		j := 0
-		for i := 0; i < len(ops); i++ {
-			if _, ok := ops[i].Request.(*pb.RequestOp_RequestRange); ok {
-				continue
-			}
-			ops[j] = ops[i]
-			j++
-		}
-
-		return ops[:j]
-	}
-
-	txn.Success = f(txn.Success)
-	txn.Failure = f(txn.Failure)
-}