Remove redundant dependencies and enforce exact pinning#1265
Merged
Conversation
Collaborator
|
Fix conflicts. |
Contributor
Author
|
@anderdc done 🫡 |
2 tasks
anderdc
requested changes
May 22, 2026
Collaborator
anderdc
left a comment
anderdc
left a comment
There was a problem hiding this comment.
Keep bittensor-cli==9.17.0 (re-add it and regenerate uv.lock). Nothing imports bittensor_cli, but it ships the btcli command — removing it strips the tool from local venvs. It is a tool dependency, not a library dependency, so the zero-call-sites read in #1264 does not apply to it. The rest of the PR — the other dep removals, exact-pinning, the dead pytz code, and the pyrightconfig.json fix — is fine.
Collaborator
|
fix conflicts |
anderdc
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1264
Summary
Audited
pyproject.tomlagainst the actual import graph and tightened both the dep list and the pinning policy.Eight redundant packages dropped:
bittensor-cli,bittensor-commit-reveal: zero direct imports anywhere, and neither is a transitive of bittensor 10.0.1bittensor-wallet: already a transitive ofbittensor; explicit pin only risked fighting the resolverlevenshtein,python-dotenv: zero direct imports; env vars are already read viaos.environfastapi,uvicornfrom[debug]: already transitives ofbittensor; the explicit pins were downgrading whatbittensorwantedpytz: only consumer wasCHICAGO_TZ+parse_github_timestamp_to_cstingittensor/validator/utils/datetime_utils.py, which chore: integrate pre-push vulture dead-code scanner #1253 found is dead codeEvery remaining direct dep is now exact-pinned (
==), replacing the previous mix of==,>=, and bare names. The lockfile andpyproject.tomlnow agree on a single resolution by construction.Held
bittensorat10.0.1: bumping needs more involved changes and is better addressed in a separate PR to avoid widening scope. The same fortree-sitterandtree-sitter-language-pack.bittensor-cli==9.17.0(runtime)import bittensor_clianywhere; not a transitive of bittensor 10.0.1bittensor-commit-reveal==0.4.0(runtime)import bittensor_commit_revealanywhere; not a transitivebittensor-wallet==4.0.0(runtime)levenshtein==0.27.3(runtime)Levenshtein,levenshtein,rapidfuzz) anywherepython-dotenv==1.2.1(runtime)load_dotenv()never called; env vars read viaos.environ.getalreadypytz==2025.2(runtime)fastapi==0.110.1(from[debug])uvicorn==0.32.0(from[debug])CHICAGO_TZconstant ingittensor/validator/utils/datetime_utils.pyparse_github_timestamp_to_cst(also dead)parse_github_timestamp_to_cst()functiongittensor/,neurons/,tests/,scripts/(per #1253)import pytzindatetime_utils.pyCHICAGO_TZremovedType of Change
Testing