Adds Repo.slug/1 helper function (#24)

* Adds Repo.slug/1 helper function

- closes #13

* Apply PR review

Author: tallysmartins

lib/elixir_bench/repos/repo.ex

@@ -16,4 +16,8 @@ defmodule ElixirBench.Repos.Repo do
     |> cast(attrs, [:owner, :name])
     |> validate_required([:owner, :name])
   end
+
+  def slug(repo) do
+    "#{repo.owner}/#{repo.name}"
+  end
 end

lib/elixir_bench_web/schema/content_types.ex

@@ -9,8 +9,7 @@ defmodule ElixirBenchWeb.Schema.ContentTypes do
     field :owner, :string
     field :name, :string
 
-    field :slug, :string,
-      resolve: fn repo, _args, _info -> {:ok, "#{repo.owner}/#{repo.name}"} end
+    field :slug, :string, resolve: fn repo, _args, _info -> {:ok, Repos.Repo.slug(repo)} end
 
     field :benchmarks, list_of(:benchmark) do
       resolve(fn %{id: id}, _, _ ->

lib/elixir_bench_web/views/job_view.ex

@@ -1,6 +1,7 @@
 defmodule ElixirBenchWeb.JobView do
   use ElixirBenchWeb, :view
   alias ElixirBenchWeb.JobView
+  alias ElixirBench.Repos
 
   def render("index.json", %{jobs: jobs, repo: repo}) do
     %{data: render_many(jobs, JobView, "job.json", repo: repo)}
@@ -13,7 +14,7 @@ defmodule ElixirBenchWeb.JobView do
   def render("job.json", %{job: %{config: config} = job, repo: repo}) do
     %{
       id: job.uuid,
-      repo_slug: "#{repo.owner}/#{repo.name}",
+      repo_slug: Repos.Repo.slug(repo),
       branch_name: job.branch_name,
       commit_sha: job.commit_sha,
       config: %{

test/elixir_bench/repos/repos_test.exs

@@ -8,6 +8,7 @@ defmodule ElixirBench.ReposTest do
     @valid_attrs %{name: "some name", owner: "some owner"}
     @update_attrs %{name: "some updated name", owner: "some updated owner"}
     @invalid_attrs %{name: nil, owner: nil}
+    @repo_slug "some owner/some name"
 
     def repo_fixture(attrs \\ %{}) do
       {:ok, repo} =
@@ -25,7 +26,7 @@ defmodule ElixirBench.ReposTest do
 
     test "get_repo!/1 returns the repo with given id" do
       repo = repo_fixture()
-      assert Repos.fetch_repo_by_slug(repo.owner <> "/" <> repo.name) == {:ok, repo}
+      assert Repos.fetch_repo_by_slug(@repo_slug) == {:ok, repo}
     end
 
     test "create_repo/1 with valid data creates a repo" do
@@ -49,18 +50,23 @@ defmodule ElixirBench.ReposTest do
     test "update_repo/2 with invalid data returns error changeset" do
       repo = repo_fixture()
       assert {:error, %Ecto.Changeset{}} = Repos.update_repo(repo, @invalid_attrs)
-      assert Repos.fetch_repo_by_slug(repo.owner <> "/" <> repo.name) == {:ok, repo}
+      assert Repos.fetch_repo_by_slug(@repo_slug) == {:ok, repo}
     end
 
     test "delete_repo/1 deletes the repo" do
       repo = repo_fixture()
       assert {:ok, %Repo{}} = Repos.delete_repo(repo)
-      assert Repos.fetch_repo_by_slug(repo.owner <> "/" <> repo.name) == {:error, :not_found}
+      assert Repos.fetch_repo_by_slug(@repo_slug) == {:error, :not_found}
     end
   end
 
   test "Repo.changeset/2 returns a repo changeset" do
     repo = repo_fixture()
     assert %Ecto.Changeset{} = Repos.Repo.changeset(repo, %{})
   end
+
+  test "Repo.slug/1 returns the repo slug" do
+    repo = repo_fixture()
+    assert @repo_slug == Repos.Repo.slug(repo)
+  end
 end