Skip to content

Commit 637aa83

Browse files
authored
Get rid of warnings and check them in CI (#36)
1 parent c2cdb06 commit 637aa83

3 files changed

Lines changed: 5 additions & 2 deletions

File tree

.travis.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@ addons:
1111
env:
1212
- MIX_ENV=test
1313

14+
before_script:
15+
- mix compile --warnings-as-errors
16+
1417
script:
1518
- mix format --check-formatted
1619
- mix safe_coveralls.travis

lib/elixir_bench/benchmarks/benchmarks.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ defmodule ElixirBench.Benchmarks do
7676
end
7777
end
7878

79-
def claim_job(%Runner{id: id} = runner) when is_nil(id), do: {:error, :not_found}
79+
def claim_job(%Runner{id: id}) when is_nil(id), do: {:error, :not_found}
8080

8181
def claim_job(%Runner{} = runner) do
8282
Repo.transaction(fn ->

lib/elixir_bench/repos/repos.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ defmodule ElixirBench.Repos do
4848
Repo.delete(repo)
4949
end
5050

51-
defp parse_slug(slug, callback) when is_nil(slug), do: {:error, :invalid_slug}
51+
defp parse_slug(slug, _callback) when is_nil(slug), do: {:error, :invalid_slug}
5252

5353
defp parse_slug(slug, callback) do
5454
case String.split(slug, "/", trim: true, parts: 2) do

0 commit comments

Comments
 (0)