Skip to content

Commit 223efd9

Browse files
authored
Merge pull request #259 from eduNEXT/jlc/fix-super-in-certificates-admin
fix: quit super with argument for certificates NELP
2 parents 749dbde + 7385f92 commit 223efd9

3 files changed

Lines changed: 8 additions & 8 deletions

File tree

lms/djangoapps/certificates/admin.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ class CertificateTemplateForm(forms.ModelForm):
2727
Django admin form for CertificateTemplate model
2828
"""
2929
def __init__(self, *args, **kwargs):
30-
super(CertificateTemplateForm, self).__init__(*args, **kwargs)
30+
super().__init__(*args, **kwargs)
3131
organizations = get_organizations()
3232
org_choices = [(org["id"], org["name"]) for org in organizations]
3333
org_choices.insert(0, ('', 'None'))
@@ -68,7 +68,7 @@ def changelist_view(self, request, extra_context=None):
6868
extra_context = {'title': mark_safe('Select Certificate Template Asset to change <br/><br/>'
6969
'<div><strong style="color: red;"> Warning!</strong> Updating '
7070
'stage asset would also update production asset</div>')}
71-
return super(CertificateTemplateAssetAdmin, self).changelist_view(request, extra_context=extra_context)
71+
return super().changelist_view(request, extra_context=extra_context)
7272

7373

7474
class GeneratedCertificateAdmin(admin.ModelAdmin):

lms/djangoapps/certificates/models.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ def get_queryset(self):
213213
Return a queryset for `GeneratedCertificate` models, filtering out
214214
ineligible certificates.
215215
"""
216-
return super(EligibleCertificateManager, self).get_queryset().exclude(
216+
return super().get_queryset().exclude(
217217
status__in=(CertificateStatuses.audit_passing, CertificateStatuses.audit_notpassing)
218218
)
219219

@@ -232,7 +232,7 @@ def get_queryset(self):
232232
Return a queryset for `GeneratedCertificate` models, filtering out
233233
ineligible certificates and any linked to nonexistent courses.
234234
"""
235-
return super(EligibleAvailableCertificateManager, self).get_queryset().extra(
235+
return super().get_queryset().extra(
236236
tables=['course_overviews_courseoverview'],
237237
where=['course_id = course_overviews_courseoverview.id']
238238
)
@@ -409,7 +409,7 @@ def save(self, *args, **kwargs):
409409
signal iff we are saving a record of a learner passing the course.
410410
As well as the COURSE_CERT_CHANGED for any save event.
411411
"""
412-
super(GeneratedCertificate, self).save(*args, **kwargs)
412+
super().save(*args, **kwargs)
413413
COURSE_CERT_CHANGED.send_robust(
414414
sender=self.__class__,
415415
user=self.user,
@@ -1205,10 +1205,10 @@ def save(self, *args, **kwargs):
12051205
if self.pk is None:
12061206
asset_image = self.asset
12071207
self.asset = None
1208-
super(CertificateTemplateAsset, self).save(*args, **kwargs)
1208+
super().save(*args, **kwargs)
12091209
self.asset = asset_image
12101210

1211-
super(CertificateTemplateAsset, self).save(*args, **kwargs)
1211+
super().save(*args, **kwargs)
12121212

12131213
def __str__(self):
12141214
return u'%s' % (self.asset.url, )

lms/djangoapps/certificates/queue.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ class XQueueAddToQueueError(Exception):
3939
def __init__(self, error_code, error_msg):
4040
self.error_code = error_code
4141
self.error_msg = error_msg
42-
super(XQueueAddToQueueError, self).__init__(six.text_type(self))
42+
super().__init__(six.text_type(self))
4343

4444
def __str__(self):
4545
return (

0 commit comments

Comments
 (0)