Do not duplicate setFocus call

akurtakov · akurtakov · commit d9c6b9039216 · 2026-04-17T13:17:15.000+03:00
Catched by review that Gtk 4 press event handling was potentially
setFocus twice.
diff --git a/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Link.java b/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Link.java
@@ -412,8 +412,7 @@ int gtk_gesture_press_event(long gesture, int n_press, double x, double y, long
 
 	if (GTK.gtk_gesture_single_get_current_button(gesture) != 1 || n_press != 1) return result;
 
-	if (focusIndex != -1) setFocus();
-		handlePress((int) x, (int) y);
+	handlePress((int) x, (int) y);
 	return result;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -412,8 +412,7 @@ int gtk_gesture_press_event(long gesture, int n_press, double x, double y, long`
`412`	`412`
`413`	`413`	`if (GTK.gtk_gesture_single_get_current_button(gesture) != 1 \|\| n_press != 1) return result;`
`414`	`414`
`415`		`- if (focusIndex != -1) setFocus();`
`416`		`- handlePress((int) x, (int) y);`
	`415`	`+ handlePress((int) x, (int) y);`
`417`	`416`	`return result;`
`418`	`417`	`}`
`419`	`418`