Skip to content

bake: deprecate x-bake compose extension#3025

Draft
crazy-max wants to merge 1 commit into
docker:masterfrom
crazy-max:x-bake-deprecated
Draft

bake: deprecate x-bake compose extension#3025
crazy-max wants to merge 1 commit into
docker:masterfrom
crazy-max:x-bake-deprecated

Conversation

@crazy-max
Copy link
Copy Markdown
Member

@crazy-max crazy-max commented Feb 25, 2025

#721 was introduced to allow the use of additional fields that were not supported by the official specification at the time. Now that the Compose specification for build is ahead, we can deprecate this extension and eventually remove it in a future release.

Note that no-cache-filter and output are not yet supported by the official specification.

@crazy-max crazy-max added this to the v0.22.0 milestone Feb 25, 2025
glours
glours approved these changes Feb 25, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@crazy-max crazy-max marked this pull request as ready for review February 25, 2025 16:54
@tonistiigi
Copy link
Copy Markdown
Member

tonistiigi commented Feb 25, 2025 •
edited
Loading

I don't get this. Is this expecting that bake will never add new fields in the definition? Plus, there are many fields in bake definition not supported in compose build block.

@crazy-max
Copy link
Copy Markdown
Member Author

crazy-max commented Feb 26, 2025

Is this expecting that bake will never add new fields in the definition? Plus, there are many fields in bake definition not supported in compose build block.

No it just means that the official compose specification needs to add new fields to build block. x-bake was meaningful when there was no parity between bake fields and the official spec at the time.

Only missing fields from the official spec that are supported today in x-bake extension are no-cache-filter and output. We can postpone deprecation until these fields made into the official spec.

@crazy-max crazy-max modified the milestones: v0.22.0, v0.23.0 Mar 7, 2025
@crazy-max crazy-max modified the milestones: v0.23.0, v0.future Mar 27, 2025
@crazy-max crazy-max self-assigned this Apr 3, 2025
@crazy-max
Copy link
Copy Markdown
Member Author

crazy-max commented Apr 7, 2025

Put this one in draft until missing fields are supported by the compose spec.

@crazy-max crazy-max marked this pull request as draft April 7, 2025 12:07
@thompson-shaun thompson-shaun modified the milestones: v0.future, v0.24.0 Apr 7, 2025
@crazy-max crazy-max removed this from the v0.24.0 milestone Apr 14, 2025
@thompson-shaun
Copy link
Copy Markdown
Collaborator

thompson-shaun commented May 1, 2025

We'll need to replace this PR with another that uses the warning path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsternberg jsternberg jsternberg approved these changes

@tonistiigi tonistiigi Awaiting requested review from tonistiigi

@thompson-shaun thompson-shaun Awaiting requested review from thompson-shaun

+1 more reviewer

@glours glours glours approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@crazy-max crazy-max

Labels

area/bake/compose area/bake

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@crazy-max @tonistiigi @thompson-shaun @glours @jsternberg