[IMP] vcp_* : improve naming of field, renaming branch_update into scheduled_branch_update for vcp.repository model.

    Add helpers. explicit limit in cron python code.

Author: legalsylvain

vcp_management/data/ir_cron.xml

@@ -24,7 +24,7 @@
         <field name="name">VCP: Branch Update</field>
         <field name="model_id" ref="model_vcp_repository" />
         <field name="state">code</field>
-        <field name="code">model._cron_update_branches()</field>
+        <field name="code">model._cron_update_branches(limit=1)</field>
         <field name="interval_number">1</field>
         <field name="interval_type">days</field>
         <field name="active">False</field>

vcp_management/models/vcp_platform.py

@@ -52,6 +52,10 @@ class VcpPlatform(models.Model):
         help="If checked, the cron that update repositories"
         " will look for up to date information, for this repository.",
     )
+    default_repository_scheduled_branch_update = fields.Boolean(
+        help="If checked, the cron that update repository branches"
+        " will look for up to date branches, for this repository.",
+    )
     scheduled_information_update = fields.Boolean(
         default=True,
         help="If checked, the cron that update platform informations"

vcp_management/models/vcp_repository.py

@@ -44,7 +44,13 @@ class VcpRepository(models.Model):
         " will look for up to date information, for this repository."
         " This update include the recovery of requests, comments and reviews.",
     )
-    branch_update = fields.Boolean(default=False)
+    scheduled_branch_update = fields.Boolean(
+        compute="_compute_scheduled_branch_update",
+        store=True,
+        readonly=False,
+        help="If checked, the cron that update repository branches"
+        " will look for up to date branches, for this repository.",
+    )
     branch_update_date = fields.Datetime(
         readonly=True, required=True, default=fields.Datetime.now
     )
@@ -82,6 +88,13 @@ def _compute_scheduled_information_update(self):
                 record.platform_id.default_repository_scheduled_information_update
             )
 
+    @api.depends("platform_id")
+    def _compute_scheduled_branch_update(self):
+        for record in self:
+            record.scheduled_branch_update = (
+                record.platform_id.default_repository_scheduled_branch_update
+            )
+
     @api.depends("request_ids")
     def _compute_request_count(self):
         for record in self:
@@ -116,9 +129,11 @@ def _cron_update_repositories(self, limit):
         for repository in repositories:
             repository.update_information()
 
-    def _cron_update_branches(self, limit=1):
+    def _cron_update_branches(self, limit):
         repositories = self.search(
-            [("branch_update", "=", True)], limit=limit, order="branch_update_date ASC"
+            [("scheduled_branch_update", "=", True)],
+            limit=limit,
+            order="branch_update_date ASC",
         )
         for repository in repositories:
             repository.update_branches()

vcp_management/tests/test_vcp_crons.py

@@ -36,7 +36,7 @@ def setUpClass(cls):
             {"scheduled_information_update": False}
         )
         cls.env["vcp.repository"].search([]).write(
-            {"scheduled_information_update": False, "branch_update": False}
+            {"scheduled_information_update": False, "scheduled_branch_update": False}
         )
         # be sure some expected values are set otherwise homepage may fail
         cls.platform = cls.env["vcp.platform"].create(
@@ -71,7 +71,7 @@ def test_platform_branch_update_no_definition(self):
                 "name": "test_repo",
                 "description": "Test Repository",
                 "platform_id": self.platform.id,
-                "branch_update": True,
+                "scheduled_branch_update": True,
                 "from_date": Date.today(),
             }
         )
@@ -98,7 +98,7 @@ def dummy_update_information(oself, *args, **kwargs):
                     "description": "Test Repository",
                     "platform_id": oself.id,
                     "scheduled_information_update": True,
-                    "branch_update": True,
+                    "scheduled_branch_update": True,
                     "from_date": Date.today(),
                 }
             )

vcp_management/views/vcp_platform.xml

@@ -60,6 +60,10 @@
                             name="default_repository_scheduled_information_update"
                             widget="boolean_toggle"
                         />
+                        <field
+                            name="default_repository_scheduled_branch_update"
+                            widget="boolean_toggle"
+                        />
                         <field name="rule_ids" widget="many2many_tags" />
                     </group>
                     <notebook>

vcp_management/views/vcp_repository.xml

@@ -84,7 +84,7 @@
                             name="scheduled_information_update"
                             widget="boolean_toggle"
                         />
-                        <field name="branch_update" />
+                        <field name="scheduled_branch_update" widget="boolean_toggle" />
                         <field name="rule_ids" widget="many2many_tags" />
                         <field name="override_parent_rules" />
                         <field name="from_date" />
@@ -146,6 +146,11 @@
                     widget="boolean_toggle"
                     optional="hide"
                 />
+                <field
+                    name="scheduled_branch_update"
+                    widget="boolean_toggle"
+                    optional="hide"
+                />
             </list>
         </field>
     </record>