[IMP] vcp_management: allow to delete pull requests

Author: legalsylvain

vcp_management/models/vcp_comment.py

@@ -38,6 +38,8 @@ class VcpComment(models.Model):
         comodel_name="vcp.request",
         string="Request",
         readonly=True,
+        required=True,
+        ondelete="cascade",
     )
     _sql_constraints = [
         ("external_id_uniq", "unique(external_id)", "External ID must be unique.")

vcp_management/models/vcp_request_label.py

@@ -3,7 +3,8 @@
 
 from random import randint
 
-from odoo import fields, models, tools
+from odoo import _, api, fields, models, tools
+from odoo.exceptions import UserError
 
 
 class VcpRequestLabel(models.Model):
@@ -14,6 +15,12 @@ class VcpRequestLabel(models.Model):
 
     color = fields.Char(default=lambda x: x._default_color())
 
+    request_ids = fields.Many2many(
+        comodel_name="vcp.request",
+        string="Requests",
+        readonly=True,
+    )
+
     _sql_constraints = [("name_uniq", "unique(name)", "Label name must be unique.")]
 
     def _default_color(self):
@@ -25,3 +32,13 @@ def _get_label(self, name):
         if not label:
             label = self.sudo().create({"name": name})
         return label.id
+
+    @api.ondelete(at_uninstall=False)
+    def _check_requests(self):
+        if self.mapped("request_ids"):
+            raise UserError(
+                _(
+                    "You can not delete labels that are related to Requests. "
+                    "You should first delete the related requests."
+                )
+            )

vcp_management/security/ir.model.access.csv

@@ -11,10 +11,13 @@ manage_repository_branch,Access Repository Branch,model_vcp_repository_branch,gr
 access_rule_information,Access Repository Branch Rule information,model_vcp_rule_information,group_vcp_user,1,0,0,0
 manage_rule_information,Access Repository Branch Rule information,model_vcp_rule_information,group_vcp_manager,1,1,1,1
 access_request,Access Pull Requests,model_vcp_request,group_vcp_user,1,0,0,0
+manage_request,Access Pull Requests,model_vcp_request,group_vcp_manager,1,1,1,1
 access_request_label,Access Pull Requests Labels,model_vcp_request_label,group_vcp_user,1,0,0,0
 manage_request_label,Access Pull Requests Labels,model_vcp_request_label,group_vcp_manager,1,1,1,1
 access_review,Access Reviews,model_vcp_review,group_vcp_user,1,0,0,0
+manage_review,Access Reviews,model_vcp_review,group_vcp_manager,1,1,1,1
 access_comment,Access Comments,model_vcp_comment,group_vcp_user,1,0,0,0
+manage_comment,Access Comments,model_vcp_comment,group_vcp_manager,1,1,1,1
 access_vcp_host_type,Access Host Type,model_vcp_host_type,group_vcp_user,1,0,0,0
 access_vcp_host,Access Hosts,model_vcp_host,group_vcp_user,1,0,0,0
 manage_vcp_host,Nabage Hosts,model_vcp_host,group_vcp_manager,1,1,1,1