chore: drop fd-lock, narrow icp tokio features, and move update_check into dist (#708)

* chore: remove unused fd-lock dependency

The `fd-lock` crate had zero source references anywhere in the
workspace; drop it from `crates/icp` and the workspace dependency
table.

* refactor: move update_check out of operations into dist

CLI self-update checking is not a library operation. Fold
`operations/update_check.rs` into `dist.rs`, which already owns the
`dist_supports_update_check`/`dist_check_for_updates` helpers it calls,
and update the single call site in `main.rs`.

* chore: narrow crates/icp tokio features from "full"

`crates/icp` only needs sync, macros, rt, time, io-util, io-std,
process and signal. The workspace `tokio` entry still supplies macros
and rt-multi-thread, the latter required by the
`tokio::task::block_in_place` call in `canister/sync/plugin.rs`.
Dropping "full" stops pulling in net and fs, which nothing in the
crate uses.

* no-mistakes(document): document narrowed tokio feature rationale in icp manifest

Author: raymondk

Cargo.lock

@@ -44,7 +44,6 @@ dunce = "1.0.5"
 ed25519-consensus = "2.1.0"
 crypto-bigint = { version = "0.5.5", features = ["zeroize"] }
 elliptic-curve = { version = "0.13.8", features = ["sec1", "std", "pkcs8"] }
-fd-lock = "4.0.4"
 flate2 = { version = "1.1.8", default-features = false, features = ["zlib-rs"] }
 futures = "0.3.31"
 glob = "0.3.2"

Cargo.toml

@@ -1,6 +1,8 @@
 use std::sync::LazyLock;
+use std::time::{Duration, SystemTime};
 
 use axoupdater::AxoUpdater;
+use icp::settings::UpdateCheck;
 use reqwest::Client;
 use tracing::debug;
 
@@ -175,3 +177,50 @@ fn newer_than_current(version_str: &str) -> bool {
     };
     latest > current
 }
+
+const ONE_DAY: Duration = Duration::from_secs(24 * 60 * 60);
+
+/// Check for CLI updates, returning the latest version string if one is available.
+pub(crate) async fn update_check(ctx: &icp::context::Context) -> Option<String> {
+    let update_check_setting = match ctx.dirs.settings() {
+        Ok(dirs) => {
+            dirs.with_read(async |dirs| icp::settings::Settings::load_from(dirs).ok())
+                .await
+                .ok()
+                .flatten()
+                .unwrap_or_default()
+                .update_check
+        }
+        Err(_) => UpdateCheck::Releases,
+    };
+
+    let enabled =
+        !matches!(update_check_setting, UpdateCheck::Disabled) && dist_supports_update_check();
+    if !enabled {
+        return None;
+    }
+    let beta = matches!(update_check_setting, UpdateCheck::Betas);
+    let nag_path = ctx.dirs.cli_update_nag_timestamp();
+
+    // Throttle to at most once per day
+    if let Ok(contents) = icp::fs::read_to_string(&nag_path)
+        && let Ok(ts) = contents.trim().parse::<u64>()
+    {
+        let then = SystemTime::UNIX_EPOCH + Duration::from_secs(ts);
+        if then.elapsed().unwrap_or(Duration::ZERO) < ONE_DAY {
+            debug!("Skipping CLI update check (last check < 24h ago)");
+            return None;
+        }
+    }
+
+    // update the timestamp regardless of result
+    let now = SystemTime::now()
+        .duration_since(SystemTime::UNIX_EPOCH)
+        .expect("since epoch")
+        .as_secs();
+    let _ = icp::fs::create_dir_all(nag_path.parent().unwrap());
+    let _ = icp::fs::write(&nag_path, format!("{now}\n").as_bytes());
+
+    let client = reqwest::Client::new();
+    dist_check_for_updates(&client, beta).await
+}

crates/icp-cli/src/dist.rs

@@ -8,9 +8,8 @@ use tracing::{Instrument, debug, info, subscriber::set_global_default, trace_spa
 use tracing_subscriber::{Registry, layer::SubscriberExt};
 
 use crate::{
-    dist::dist_update_suggestion,
+    dist::{dist_update_suggestion, update_check},
     logging::{UserLayer, debug_layer},
-    operations::update_check::update_check,
     version::{git_sha, icp_cli_version_str},
 };
 

crates/icp-cli/src/main.rs

@@ -14,5 +14,4 @@ pub(crate) mod sync;
 pub(crate) mod token;
 
 pub(crate) mod misc;
-pub(crate) mod update_check;
 pub(crate) mod wasm;

crates/icp-cli/src/operations/mod.rs

@@ -21,7 +21,6 @@ directories = { workspace = true }
 dunce = { workspace = true }
 ed25519-consensus = { workspace = true }
 elliptic-curve = { workspace = true }
-fd-lock = { workspace = true }
 flate2 = { workspace = true }
 futures = { workspace = true }
 glob = { workspace = true }
@@ -68,7 +67,11 @@ sysinfo = { workspace = true }
 tar = { workspace = true }
 time = { workspace = true }
 tiny-bip39 = { workspace = true }
-tokio = { workspace = true, features = ["full"] }
+# `io-std` is listed for `tokio::io::stdout`/`stderr`; feature unification with other
+# crates supplies it anyway, so dropping it would not fail the build. `rt-multi-thread`
+# is needed by `block_in_place` in `canister::sync::plugin` and arrives via the
+# workspace `tokio` entry.
+tokio = { workspace = true, features = ["sync", "macros", "rt", "time", "io-util", "io-std", "process", "signal"] }
 tracing = { workspace = true }
 url = { workspace = true }
 uuid = { workspace = true }