Rename check_compatibility to check_avx512_compatibility

Author: r-devulap

jvector-native/src/main/c/jvector_simd.c

@@ -26,7 +26,7 @@ __m512i maskEighthBit;
 
 __attribute__((constructor))
 void initialize_constants() {
-    if (check_compatibility()) {
+    if (check_avx512_compatibility()) {
         initialIndexRegister = _mm512_setr_epi32(-16, -15, -14, -13, -12, -11, -10, -9,
                                              -8, -7, -6, -5, -4, -3, -2, -1);
         indexIncrement = _mm512_set1_epi32(16);

jvector-native/src/main/c/jvector_simd.h

@@ -20,7 +20,7 @@
 #define VECTOR_SIMD_DOT_H
 
 // check CPU support
-bool check_compatibility(void);
+bool check_avx512_compatibility(void);
 
 //F32
 float dot_product_f32(int preferred_size, const float* a, int aoffset, const float* b, int boffset, int length);

jvector-native/src/main/c/jvector_simd_check.c

@@ -17,7 +17,10 @@
 #include <cpuid.h>
 #include "jvector_simd.h"
 
-bool check_compatibility(void) {
+bool check_avx512_compatibility(void) {
+    /* __builtin_cpu_init required when this is used in ifunc
+       resolver/__attribute__((constructor)) context, otherwise the CPU
+       features may not be detected correctly. */
     __builtin_cpu_init();
     return (__builtin_cpu_supports("avx512f") &&
         __builtin_cpu_supports("avx512cd") &&

jvector-native/src/main/java/io/github/jbellis/jvector/vector/NativeVectorizationProvider.java

@@ -35,7 +35,7 @@ public NativeVectorizationProvider() {
         if (!libraryLoaded) {
             throw new UnsupportedOperationException("Failed to load supporting native library.");
         }
-        if (!NativeSimdOps.check_compatibility()) {
+        if (!NativeSimdOps.check_avx512_compatibility()) {
             throw new UnsupportedOperationException("Native SIMD operations are not supported on this platform due to missing CPU support.");
         }
         this.vectorUtilSupport = new NativeVectorUtilSupport();

jvector-native/src/main/java/io/github/jbellis/jvector/vector/cnative/NativeSimdOps.java

@@ -96,55 +96,55 @@ public static int __bool_true_false_are_defined() {
         return __bool_true_false_are_defined;
     }
 
-    private static class check_compatibility {
+    private static class check_avx512_compatibility {
         public static final FunctionDescriptor DESC = FunctionDescriptor.of(
                 NativeSimdOps.C_BOOL    );
 
-        public static final MemorySegment ADDR = NativeSimdOps.findOrThrow("check_compatibility");
+        public static final MemorySegment ADDR = NativeSimdOps.findOrThrow("check_avx512_compatibility");
 
         public static final MethodHandle HANDLE = Linker.nativeLinker().downcallHandle(ADDR, DESC, Linker.Option.critical(true));
     }
 
     /**
      * Function descriptor for:
      * {@snippet lang=c :
-     * _Bool check_compatibility()
+     * _Bool check_avx512_compatibility()
      * }
      */
-    public static FunctionDescriptor check_compatibility$descriptor() {
-        return check_compatibility.DESC;
+    public static FunctionDescriptor check_avx512_compatibility$descriptor() {
+        return check_avx512_compatibility.DESC;
     }
 
     /**
      * Downcall method handle for:
      * {@snippet lang=c :
-     * _Bool check_compatibility()
+     * _Bool check_avx512_compatibility()
      * }
      */
-    public static MethodHandle check_compatibility$handle() {
-        return check_compatibility.HANDLE;
+    public static MethodHandle check_avx512_compatibility$handle() {
+        return check_avx512_compatibility.HANDLE;
     }
 
     /**
      * Address for:
      * {@snippet lang=c :
-     * _Bool check_compatibility()
+     * _Bool check_avx512_compatibility()
      * }
      */
-    public static MemorySegment check_compatibility$address() {
-        return check_compatibility.ADDR;
+    public static MemorySegment check_avx512_compatibility$address() {
+        return check_avx512_compatibility.ADDR;
     }
 
     /**
      * {@snippet lang=c :
-     * _Bool check_compatibility()
+     * _Bool check_avx512_compatibility()
      * }
      */
-    public static boolean check_compatibility() {
-        var mh$ = check_compatibility.HANDLE;
+    public static boolean check_avx512_compatibility() {
+        var mh$ = check_avx512_compatibility.HANDLE;
         try {
             if (TRACE_DOWNCALLS) {
-                traceDowncall("check_compatibility");
+                traceDowncall("check_avx512_compatibility");
             }
             return (boolean)mh$.invokeExact();
         } catch (Throwable ex$) {