Replies: 2 comments 2 replies
|
You might be right. If refactoring works, I see no reason not to do that simplification. |
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
I currently don't see why
visit_all_productsshould return anything. We are just inspecting single products and always need context from the outside and populate some external collection.As we don't break on the first occurrence of an error and always want to visit all products, I think we can simplify this method.
What are your thoughts? @milux @oxisto @peinjoh
All reactions