Skip to content

modeld: single jit#37758

Draft
Armandpl wants to merge 82 commits intomasterfrom
modeld-single-jit2
Draft

modeld: single jit#37758
Armandpl wants to merge 82 commits intomasterfrom
modeld-single-jit2

Conversation

@Armandpl
Copy link
Copy Markdown
Contributor

@Armandpl Armandpl commented Apr 2, 2026 •
edited
Loading

  • test vs. compile
    • double check not hitting uop cache collision bug
  • test vs. onnx runtime
  • input queues what do: need them to work both for numpy and tg tensors
  • prepare only
    • compile a warp only jit and warm it up?
    • skip frame in some other way?
  • double check if there's any ops we can skip
  • how do we want to handle compile_supercombo in xx? i think validating with compile3 still makes sense
    • refactor later

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026 •
edited
Loading

Process replay diff report

Replays driving segments through this PR and compares the behavior to master.
Please review any changes carefully to ensure they are expected.

✅ 0 changed, 66 passed, 0 errors

@commaci-public
Copy link
Copy Markdown
Contributor

commaci-public commented Apr 2, 2026 •
edited
Loading

ref for commit 7a59ed9: https://raw.githubusercontent.com/commaai/ci-artifacts/refs/heads/model_replay_modeld-single-jit2/8494c69d3c710e81|000001d4--2648a9a404_model_tici_7a59ed9b1ac88657b5a3917986b6ff92e59a2ee3.zst

All Model Replay Plots

@Armandpl Armandpl force-pushed the modeld-single-jit2 branch from 22fe638 to 98c62ff Compare April 4, 2026 06:22
Armandpl added 27 commits April 6, 2026 15:21
@Armandpl
compile_modeld.py
56a0571
@Armandpl
update estimates
ed6089f
@Armandpl
missing image=2?
5834b42
@Armandpl
Revert "missing image=2?"
d005cd1 
This reverts commit 2f5952e.
@Armandpl
Revert "update estimates"
919b263 
This reverts commit 1f72fee.
@Armandpl
Revert "compile_modeld.py"
ff2da85 
This reverts commit f105415.
@Armandpl
load warp in ModelState init
6f3dfef
@Armandpl
dead code
0f3a276
@Armandpl
prep
a5a7a22
@Armandpl
compile modeld
f43c3ea
@Armandpl
update SConscript
8d93837
@Armandpl
tmp save plot locally
ec8a43d
@Armandpl
Revert "tmp save plot locally"
2f65af2 
This reverts commit ec22f15.
@Armandpl
openpilot hacks?
53e84ff
@Armandpl
no float16
ab0ad4b
@Armandpl
tmp more chunks
f133a16
@Armandpl
Revert "tmp more chunks"
fe21f55 
This reverts commit 9e1d9b4.
@Armandpl
Revert "no float16"
ff25362 
This reverts commit 6204956.
@Armandpl
realize boundaries
db26a67
@Armandpl
Revert "realize boundaries"
e490560 
This reverts commit ffaa192.
@Armandpl
prune=False?
b64e152
@Armandpl
Reapply "tmp more chunks"
9625b94 
This reverts commit 2599c41.
@Armandpl
tg bug?
9285441
@Armandpl
load first?
27e0350
@Armandpl
Revert "load first?"
406b350 
This reverts commit f643d08.
@Armandpl
revert
dc1191b
@Armandpl
Reapply "tmp save plot locally"
0cfb91a 
This reverts commit 1b95b82.
haraschax and others added 30 commits April 7, 2026 23:34
@haraschax @claude
modeld: create SubMaster before model loading
968c987 
Move PubMaster/SubMaster creation before the model loading step.
During model loading (3.5s+), process_replay may send liveCalibration.
If SubMaster doesn't exist yet, the message is dropped and the warp
transform stays as zeros, producing garbage warped images.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@haraschax
Revert "modeld: create SubMaster before model loading"
051e6de 
This reverts commit 968c987.
@Armandpl
stale metadata?
8703885
@Armandpl
claude debug
49e754c
@Armandpl
Revert "claude debug"
8e95790 
This reverts commit 49e754c.
@Armandpl
Revert "stale metadata?"
fc431c7 
This reverts commit 8703885.
@haraschax
modeld: realize jit outputs before parsing
c534e43
@haraschax
Update modeld.py
557a75d
@haraschax
Merge branch 'master' into modeld-single-jit2
a6df299 
# Conflicts:
#	selfdrive/modeld/SConscript
#	selfdrive/modeld/modeld.py
@haraschax
modeld: fix NameError by removing redundant MODELS_DIR definition
129f77b
@Armandpl
test buffers in test vs. compile
2e9d4e5
@Armandpl
2x inputs before running
8dd7c39
@Armandpl
fixup 2x inputs test
dac6c75
@Armandpl
realize onnx weights?
49c8b9a
@Armandpl
Revert "realize onnx weights?"
b6ab553 
This reverts commit 49c8b9a.
@Armandpl
move openpilot_hacks flag to sconscript
64a415d
@Armandpl
stricter test vs compile
c11099e
@Armandpl
correct timings
269c9a0
@Armandpl
more run more fail?
9e94bb6
@Armandpl
Revert "more run more fail?"
e1c41ce 
This reverts commit 9e94bb6.
@Armandpl
numpy shenanigans
b4f6fb3
@Armandpl
correct shapes
5b9ff6c
@Armandpl
dont assert timings for now
a2c17ea
@Armandpl
Revert "correct shapes"
f6eb0de 
This reverts commit 5b9ff6c.
@Armandpl
Revert "numpy shenanigans"
33a6dca 
This reverts commit b4f6fb3.
@Armandpl
no need to nuke
476ed41
@Armandpl
comment unused
ac79f49
@Armandpl
don't use NPY device
18abf43
@Armandpl
copy instead of from_blob
196c489
@Armandpl
to device before jit
7a59ed9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Armandpl @commaci-public @haraschax