Skip to content

Commit b6903bc

Browse files
David Engelhartclaude
andcommitted
lumopolis: a new e2e opens Lumopolis on a project under a path with spaces and checks the renderer, cards, floors, tour, 2D map, design world, forward slashes, case-only file names and the lumopolis command in bash and zsh, and CI runs it on macOS and Linux with screenshots and a video kept 14 days
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 parent 6013586 commit b6903bc

2 files changed

Lines changed: 567 additions & 0 deletions

File tree

‎.github/workflows/test.yml‎

Lines changed: 95 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -504,6 +504,9 @@ jobs:
504504
# warning it leaves names the native frame the quit is stuck in.
505505
- name: Install gdb
506506
run: sudo apt-get install -y --no-install-recommends gdb || true
507+
# e2e/world-platform.spec.ts types `lumopolis` in bash and in zsh, and fails in CI when either is missing.
508+
- name: Install zsh
509+
run: sudo apt-get install -y --no-install-recommends zsh
507510
- name: Build
508511
run: npm run build
509512
# e2e/linux-sandbox.spec.ts launches with Chromium's sandbox ON (issue #32), which needs
@@ -536,6 +539,33 @@ jobs:
536539
name: playwright-traces-full-${{ matrix.shard }}
537540
path: test-results/
538541
retention-days: 7
542+
# The Lumopolis screenshots and video (e2e/world-platform.spec.ts, e2e/world-visual.spec.ts), kept two weeks.
543+
# Only the shard that ran those specs has them; e2e-lumopolis-linux-shots merges the shards into one artifact.
544+
- name: Upload Lumopolis screenshots
545+
if: ${{ !cancelled() }}
546+
uses: actions/upload-artifact@v4
547+
with:
548+
name: lumopolis-shots-linux-shard${{ matrix.shard }}
549+
path: |
550+
test-results/lumopolis-shots/
551+
test-results/world-visual/
552+
if-no-files-found: ignore
553+
retention-days: 14
554+
555+
# The Linux Lumopolis screenshots as one artifact, named for the OS like the macOS job's.
556+
e2e-lumopolis-linux-shots:
557+
needs: e2e-full
558+
if: ${{ !cancelled() }}
559+
runs-on: ubuntu-latest
560+
continue-on-error: true
561+
timeout-minutes: 10
562+
steps:
563+
- uses: actions/upload-artifact/merge@v4
564+
with:
565+
name: lumopolis-shots-linux
566+
pattern: lumopolis-shots-linux-shard*
567+
delete-merged: true
568+
retention-days: 14
539569

540570
# THE Windows e2e gate: the whole e2e directory again, blocking, sharded 4 ways like e2e-full.
541571
#
@@ -693,3 +723,68 @@ jobs:
693723
name: playwright-traces-macos
694724
path: test-results/
695725
retention-days: 7
726+
727+
# Lumopolis on macOS: every world spec (e2e/world*.spec.ts), where e2e-smoke-macos runs only the export. Linux
728+
# runs them in e2e-full and Windows in e2e-windows. e2e/world-platform.spec.ts records the renderer (WebGL on
729+
# SwiftShader, or the 2D list) in the step summary, checks the platform's paths, file names and the `lumopolis`
730+
# shell command in bash and zsh, and saves a screenshot at each key moment and a video, uploaded for two weeks.
731+
# Not blocking until it has been green twice in a row.
732+
e2e-lumopolis-macos:
733+
needs: [static, model]
734+
runs-on: macos-latest
735+
continue-on-error: true
736+
timeout-minutes: 60
737+
env:
738+
TERMPOLIS_E2E_PREBUILT: '1'
739+
steps:
740+
- uses: actions/checkout@v6
741+
- uses: actions/setup-node@v6
742+
with:
743+
node-version: 22
744+
cache: npm
745+
- name: Install dependencies
746+
shell: bash
747+
run: |
748+
for i in 1 2 3; do
749+
npm install && break
750+
echo "npm install failed (attempt $i), cleaning cache and retrying..."
751+
npm cache clean --force || true
752+
sleep 10
753+
done
754+
# world-export.spec.ts exports a world with the bundled embedding model, as in e2e-smoke-macos.
755+
- name: Restore the embedding model
756+
uses: actions/cache/restore@v4
757+
with:
758+
path: resources/models
759+
key: ${{ needs.model.outputs.key }}
760+
enableCrossOsArchive: true
761+
fail-on-cache-miss: true
762+
- name: Install Playwright browsers
763+
run: npx playwright install --with-deps chromium
764+
- name: Build
765+
run: npm run build
766+
# As in e2e-smoke-macos: node-pty's prebuilt spawn-helper can land without +x.
767+
- name: Fix spawn-helper permissions (macOS)
768+
run: |
769+
find node_modules/node-pty -name "spawn-helper" -type f -exec chmod 755 {} \; -print
770+
# The step's timeout sits under the job's, so the uploads below still run when it runs out.
771+
- name: Lumopolis world specs (macOS)
772+
timeout-minutes: 50
773+
run: npx playwright test e2e/world --reporter=list
774+
- name: Upload Lumopolis screenshots
775+
if: ${{ !cancelled() }}
776+
uses: actions/upload-artifact@v4
777+
with:
778+
name: lumopolis-shots-macos
779+
path: |
780+
test-results/lumopolis-shots/
781+
test-results/world-visual/
782+
if-no-files-found: warn
783+
retention-days: 14
784+
- name: Upload failure traces
785+
if: failure()
786+
uses: actions/upload-artifact@v4
787+
with:
788+
name: playwright-traces-lumopolis-macos
789+
path: test-results/
790+
retention-days: 7

0 commit comments

Comments
 (0)