feat: use request.app.url_for (#446)

add

chore:refractor

Update reverse.py

add

add

add

add

Update reverse.py

add

add beat back

add

add

feat: use request.app.url_path_for

Update login.py

add

Author: baseplate-admin

src/backend/app/routes/http/login.py

@@ -49,5 +49,3 @@ async def login_endpoint(
     )
 
     return Token(access_token=token_string, token_type="bearer")
-
-

src/backend/app/routes/http/reverse.py

@@ -4,7 +4,7 @@
 from urllib.parse import quote
 
 from botocore.exceptions import ClientError
-from fastapi import APIRouter, Header, HTTPException, UploadFile, status, Request
+from fastapi import APIRouter, Header, HTTPException, Request, UploadFile, status
 from fastapi.responses import StreamingResponse
 from sqlmodel import col, select
 from types_aiobotocore_s3.type_defs import CompletedPartTypeDef
@@ -20,8 +20,8 @@
     RoomOut,
 )
 from app.settings import settings
-from app.states.room import RoomState
 from app.states.app import UploadProgress
+from app.states.room import RoomState
 from app.tasks.clean_file import delete_expired_file
 from app.tasks.persist_file import persist_file_record
 
@@ -86,7 +86,6 @@ async def add_host(
 async def upload_file_to_room(
     room_id: str,
     file: UploadFile,
-    file: UploadFile,
     request: Request,
     s3: S3Dep,
     x_host_token: str = Header(),
@@ -208,13 +207,13 @@ async def upload_file_to_room(
         filename=filename,
         size=uploaded_size,
         uploaded_at=now,
-        download_url=f"{settings.ROOT_PATH}/download/{file_key}",
+        download_url=str(request.app.url_path_for("download_files", key=file_key)),
     )
 
     # Persist in room state + fan-out event via pub/sub (atomic append)
     added = await RoomState.add_file(room_id, entry)
     if not added:
-        # Room vanished mid-upload — clean up the S3 object
+        # Room vanished mid-upload clean up the S3 object
         await s3.delete_object(Bucket=settings.RUSTFS_BUCKET_NAME, Key=file_key)
         # Remove in-flight upload from global state
         await UploadProgress.cancel(upload_key=file_key)

src/backend/app/routes/ws/reverse.py

@@ -20,7 +20,7 @@
 async def _stream_file_to_ws(ws: WebSocket, entry: RoomFileEntry) -> None:
     """Fetch a file from RustFS and relay every chunk to *ws*.
 
-    Mirrors the streaming pattern in ``download.py`` — the client receives raw
+    Mirrors the streaming pattern in ``download.py`` - the client receives raw
     bytes without ever knowing about the backing S3 store.
     """
     session = aioboto3.Session()
@@ -46,7 +46,7 @@ async def _stream_file_to_ws(ws: WebSocket, entry: RoomFileEntry) -> None:
             )
             return
 
-        # Header — tells the client which file is coming and how large it is
+        # Header - tells the client which file is coming and how large it is
         await ws.send_text(
             json.dumps(
                 {
@@ -58,14 +58,14 @@ async def _stream_file_to_ws(ws: WebSocket, entry: RoomFileEntry) -> None:
             )
         )
 
-        # Binary chunks — same as ``async for chunk in s3_response["Body"]``
+        # Binary chunks - same as ``async for chunk in s3_response["Body"]``
         try:
             async for chunk in s3_response["Body"]:
                 await ws.send_bytes(chunk)
         finally:
             s3_response["Body"].close()
 
-        # Footer — signals the client that this file is complete
+        # Footer - signals the client that this file is complete
         await ws.send_text(json.dumps({"type": "file_end", "key": entry.key}))
 
 
@@ -87,15 +87,15 @@ async def room_ws(ws: WebSocket, room_id: str, host_token: str | None = None):
 
     await ws.accept()
 
-    # ── subscribe FIRST so no events are lost between snapshot and listen ──
+    # subscribe FIRST so no events are lost between snapshot and listen
     sub_client = aioredis.from_url(
         settings.REDIS_ENDPOINT, encoding="utf-8", decode_responses=True
     )
     pubsub = sub_client.pubsub()
     channel = RoomState.channel_for(room_id)
     await pubsub.subscribe(channel)
 
-    # ── snapshot (re-read after subscribe to guarantee consistency) ───
+    # snapshot (re-read after subscribe to guarantee consistency)
     room = await RoomState.get(room_id)
     if room is None:
         await pubsub.unsubscribe(channel)
@@ -137,14 +137,14 @@ async def _listen_events() -> None:
                 except Exception:
                     continue
 
-                # Host destroyed the room — notify client and close
+                # Host destroyed the room - notify client and close
                 if data.get("type") == "room_destroyed":
                     await ws.send_text(json.dumps({"type": "room_destroyed"}))
                     file_queue.put_nowait(None)
                     await ws.close(code=4001, reason="Room destroyed by host")
                     return
 
-                # Host count changed — forward directly
+                # Host count changed - forward directly
                 if data.get("type") == "host_count":
                     await ws.send_text(json.dumps(data))
                     continue
@@ -157,7 +157,7 @@ async def _listen_events() -> None:
 
                 if event.event == "file_added":
                     if event.file.key in seen_keys:
-                        # Already queued from the snapshot — skip duplicate
+                        # Already queued from the snapshot - skip duplicate
                         continue
                     seen_keys.add(event.file.key)
                     file_queue.put_nowait(event.file)
@@ -174,7 +174,7 @@ async def _listen_events() -> None:
         except WebSocketDisconnect, asyncio.CancelledError:
             pass
 
-    # ── streamer — pulls from queue and streams one file at a time ───
+    # pulls from queue and streams one file at a time
     async def _stream_queued_files() -> None:
         try:
             while True:
@@ -189,7 +189,7 @@ async def _stream_queued_files() -> None:
     stream_task = asyncio.create_task(_stream_queued_files())
 
     try:
-        # Keep alive — read (and discard) client pings / messages
+        # Keep alive - read (and discard) client pings / messages
         while True:
             await ws.receive_text()
     except WebSocketDisconnect:

src/backend/app/routes/ws/state.py

@@ -15,7 +15,7 @@ async def state_ws(ws: WebSocket):
         current: AppState = await AppState.get()
         await ws.send_text(current.model_dump_json())
 
-        # Keep the connection alive — read (and discard) client pings/messages
+        # Keep the connection alive - read (and discard) client pings/messages
         while True:
             await ws.receive_text()
     except WebSocketDisconnect:

src/backend/app/schemas/reverse.py

@@ -21,7 +21,7 @@ class RoomOut(BaseModel):
 
 
 class RoomCreateOut(RoomOut):
-    """Returned only once at room creation — includes the host secret."""
+    """Returned only once at room creation - includes the host secret."""
 
     host_token: str
 

src/backend/app/states/room.py

@@ -164,7 +164,7 @@ async def add_file(cls, room_id: str, entry: RoomFileEntry) -> bool:
             # Key doesn't exist (room expired) or path missing
             return False
 
-        # Fan-out notification — every subscribed instance picks this up
+        # Fan-out notification - every subscribed instance picks this up
         event = RoomFileEvent(event="file_added", file=entry)
         await cls._publish(_room_channel(room_id), event.model_dump_json())
         return True