fix(ci): skip lidar ament linters in package pytest config

PYTEST_ADDOPTS -m not linter never reached ament pytest, so copyright /
flake8 / pep257 still ran after the unit tests passed. Ignore those
modules in setup.cfg and collect_ignore.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: pvkumara5

robot/ros_ws/src/sensors/lidar_point_cloud_filter/setup.cfg

@@ -10,3 +10,13 @@ python_classes = Test*
 python_functions = test_*
 markers =
     unit: Hermetic unit tests (no ROS stack required)
+    linter: ament copyright/flake8/pep257 (run separately, not via colcon test)
+    copyright: ament_copyright
+    flake8: ament_flake8
+    pep257: ament_pep257
+# colcon test / PYTEST_ADDOPTS -m is dropped by ament pytest. Ignore linter
+# modules here so only unit tests run.
+addopts =
+    --ignore=test/test_copyright.py
+    --ignore=test/test_flake8.py
+    --ignore=test/test_pep257.py

robot/ros_ws/src/sensors/lidar_point_cloud_filter/test/conftest.py

@@ -0,0 +1,7 @@
+# Skip ament linter modules during pytest/colcon test.
+# PYTEST_ADDOPTS -m is not forwarded by ament pytest; collect_ignore is.
+collect_ignore = [
+    "test_copyright.py",
+    "test_flake8.py",
+    "test_pep257.py",
+]

tests/colcon_unit_test_packages.yaml

@@ -9,10 +9,7 @@ robot:
   packages:
     - natnet_ros2
     - lidar_point_cloud_filter
-  # Skips ament_copyright / flake8 / pep257 on Python packages; run linters separately.
-  # launch_testing is disabled via PYTEST_DISABLE_PLUGIN_AUTOLOAD in the test
-  # ( -p no:launch_testing is too late: pytest 8.1+ validates the plugin at
-  # register, before -p is applied).
-  pytest_args:
-    - -m
-    - not linter
+  # Linter skip lives in lidar_point_cloud_filter setup.cfg + test/conftest.py.
+  # ament pytest does not honor PYTEST_ADDOPTS -m.
+  # launch_testing is skipped via PYTEST_DISABLE_PLUGIN_AUTOLOAD in the test.
+  pytest_args: []

tests/system/test_build_packages.py

@@ -71,10 +71,10 @@ def test_colcon_test_robot(self):
             )
             assert build.returncode == 0, f"colcon build (with testing) failed:\n{read_log_tail()}"
 
-            # PYTEST_ADDOPTS via docker exec -e (not colcon --pytest-args).
             # PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 skips launch_testing before
-            # pytest 8.1+ validates its removed path= hook. -p no:launch_testing
-            # is too late. Needed on cache_* images that predate the pytest<8.1 pin.
+            # pytest 8.1+ validates its removed path= hook. Linter skip is in
+            # the package setup.cfg / test/conftest.py (ament pytest ignores
+            # PYTEST_ADDOPTS -m).
             exec_env = {"PYTEST_DISABLE_PLUGIN_AUTOLOAD": "1"}
             if pytest_args:
                 exec_env["PYTEST_ADDOPTS"] = format_pytest_addopts(pytest_args)