Repository navigation
cockpit: chats you can find, each a messenger - #230
Merged
Merged
Conversation
- /chats/<thread> opens the conversation as a page: back to Chats, who answers, newest at the bottom, the box at the bottom; it is the node chat of the thread's node (the same component as on node pages), so system events stay behind Activity and live cards still show - a sent message shows at once as "Sending…" and the box empties; a refusal puts the words back with "Not sent: <the server's reason>" - an agent's message longer than six lines folds under "more" - tests: messenger send and refusal, fold, the thread page; e2e Chats on a real server at 1440 and 390 - web lint and type-check green again on staging (useFactory, a test) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
❌ UI Snapshot doesn't match the committed baseline. If this UI change is intentional, update the baseline — each path renders in the same pinned image, so the result matches this gate:
Diff PNGs ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes # (cockpit UI iteration, part 2 of 3)
Summary
Luka: "chat feel wonky and too verbose. and i feel like i cannot find the chats that i wrote in."
ELI5: Chats (in the sidebar since #229) lists every conversation, yours first. Clicking one now opens it like a normal messenger: the name and who answers at the top, the newest message at the bottom, the box at the bottom. When you press Enter the message shows right away as "Sending…"; if the server refuses, your words come back into the box with the reason. Long agent messages fold to six lines with "more".
ChatThreadPagerendersNodeChatwithlayout="page"and the thread's key: one component for the node page's chat column and for Chats, so lanes (conversation vs Activity), cards, the/menu and read marks behave the same. Its own title and the children's news are left out on the page (the page header names the chat).RoomThreadView.sendadds the message to the thread at once (pending, never counted as read), swaps in the server's row, drops it on a refusal;RoomComposerempties the box on Enter and restores it withNot sent: …on failure.RoomMessagefolds an agent's body taller than six lines (more/less).useFactory.tsmethod signature, a test's possibly-undefined index), and drops the v2 Decisions page's feedback test that cockpit: one cockpit for everyone, a sidebar, Home and Demos #229 orphaned.Test Plan
npx vitest run: 549 files, 10391 tests green;tsc -b,oxlint,prettier --checkclean.NodeChat.test.tsx"the chat is a messenger" (sent at once, box empties; refused words come back with the reason; long agent message folds),Cockpit.test.tsx"a chat" (thread page layout, header, back link).tests/e2e_ui/factory_v3/test_v3_chats.pyon a real server (1440, 390): your thread first withmine, opens as a messenger, no system events inline, box above the phone tab bar, send shows at once and stays, the list shows "You: …" after.test_v3_calm.pygreen.Demo
Screenshots (1440 light/dark, 390) in
wt/v3-tmp/ui-cockpit/shots/pr2/on the build machine (chats, thread, project); attachment upload is not available from this session.Type of change
Test coverage
Coverage notes
Manual: opened #factory and a project thread at 1440 and 390 against a local server seeded with
seed_factory_1340, sent messages, checked the fold and the Activity line.Changelog
Chats open as a messenger: your conversations first, a sent message shows at once, long agent messages fold
🤖 Generated with Claude Code