Skip to content

Commit 258b532

Browse files
committed
Upgrade acmez to v3; other dependencies as well
1 parent d2a983d commit 258b532

15 files changed

Lines changed: 35 additions & 31 deletions

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ CertMagic - Automatic HTTPS using Let's Encrypt
9090
- Exponential backoff with carefully-tuned intervals
9191
- Retries with optional test/staging CA endpoint instead of production, to avoid rate limits
9292
- Written in Go, a language with memory-safety guarantees
93-
- Powered by [ACMEz](https://github.com/mholt/acmez/v2), _the_ premier ACME client library for Go
93+
- Powered by [ACMEz](https://github.com/mholt/acmez/v3), _the_ premier ACME client library for Go
9494
- All [libdns](https://github.com/libdns) DNS providers work out-of-the-box
9595
- Pluggable storage backends (default: file system)
9696
- Pluggable key sources
@@ -567,7 +567,7 @@ We welcome your contributions! Please see our **[contributing guidelines](https:
567567

568568
## Project History
569569

570-
CertMagic is the core of Caddy's advanced TLS automation code, extracted into a library. The underlying ACME client implementation is [ACMEz](https://github.com/mholt/acmez/v2). CertMagic's code was originally a central part of Caddy even before Let's Encrypt entered public beta in 2015.
570+
CertMagic is the core of Caddy's advanced TLS automation code, extracted into a library. The underlying ACME client implementation is [ACMEz](https://github.com/mholt/acmez/v3). CertMagic's code was originally a central part of Caddy even before Let's Encrypt entered public beta in 2015.
571571

572572
In the years since then, Caddy's TLS automation techniques have been widely adopted, tried and tested in production, and served millions of sites and secured trillions of connections.
573573

account.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ import (
3232
"strings"
3333
"sync"
3434

35-
"github.com/mholt/acmez/v2/acme"
35+
"github.com/mholt/acmez/v3/acme"
3636
"go.uber.org/zap"
3737
)
3838

acmeclient.go

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import (
1818
"context"
1919
"crypto/x509"
2020
"fmt"
21+
"log/slog"
2122
"net"
2223
"net/http"
2324
"net/url"
@@ -26,9 +27,10 @@ import (
2627
"sync"
2728
"time"
2829

29-
"github.com/mholt/acmez/v2"
30-
"github.com/mholt/acmez/v2/acme"
30+
"github.com/mholt/acmez/v3"
31+
"github.com/mholt/acmez/v3/acme"
3132
"go.uber.org/zap"
33+
"go.uber.org/zap/exp/zapslog"
3234
)
3335

3436
// acmeClient holds state necessary to perform ACME operations
@@ -276,7 +278,7 @@ func (iss *ACMEIssuer) newBasicACMEClient() (*acmez.Client, error) {
276278
Directory: caURL,
277279
UserAgent: buildUAString(),
278280
HTTPClient: iss.httpClient,
279-
Logger: iss.Logger.Named("acme_client"),
281+
Logger: slog.New(zapslog.NewHandler(iss.Logger.Named("acme_client").Core(), nil)),
280282
},
281283
}, nil
282284
}

acmeissuer.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ import (
2828
"sync"
2929
"time"
3030

31-
"github.com/mholt/acmez/v2"
32-
"github.com/mholt/acmez/v2/acme"
31+
"github.com/mholt/acmez/v3"
32+
"github.com/mholt/acmez/v3/acme"
3333
"go.uber.org/zap"
3434
)
3535

@@ -482,7 +482,7 @@ func (am *ACMEIssuer) doIssue(ctx context.Context, csr *x509.CertificateRequest,
482482
zap.String("account_id", client.account.Location),
483483
zap.Strings("account_contact", client.account.Contact),
484484
zap.String("key_location", am.storageKeyUserPrivateKey(client.acmeClient.Directory, am.getEmail())),
485-
zap.Object("problem", prob))
485+
zap.Any("problem", prob))
486486

487487
// the account we have no longer exists on the CA, so we need to create a new one;
488488
// we could use the same key pair, but this is a good opportunity to rotate keys

certificates.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ import (
2626
"strings"
2727
"time"
2828

29-
"github.com/mholt/acmez/v2/acme"
29+
"github.com/mholt/acmez/v3/acme"
3030
"go.uber.org/zap"
3131
"golang.org/x/crypto/ocsp"
3232
)

config.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ import (
3535
"strings"
3636
"time"
3737

38-
"github.com/mholt/acmez/v2"
39-
"github.com/mholt/acmez/v2/acme"
38+
"github.com/mholt/acmez/v3"
39+
"github.com/mholt/acmez/v3/acme"
4040
"go.uber.org/zap"
4141
"golang.org/x/crypto/ocsp"
4242
"golang.org/x/net/idna"

config_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import (
2222
"reflect"
2323
"testing"
2424

25-
"github.com/mholt/acmez/v2/acme"
25+
"github.com/mholt/acmez/v3/acme"
2626
)
2727

2828
func TestSaveCertResource(t *testing.T) {

go.mod

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,15 @@ toolchain go1.22.2
66

77
require (
88
github.com/caddyserver/zerossl v0.1.3
9-
github.com/klauspost/cpuid/v2 v2.2.8
9+
github.com/klauspost/cpuid/v2 v2.2.9
1010
github.com/libdns/libdns v0.2.2
11-
github.com/mholt/acmez/v2 v2.0.3
11+
github.com/mholt/acmez/v3 v3.0.0
1212
github.com/miekg/dns v1.1.62
1313
github.com/zeebo/blake3 v0.2.4
1414
go.uber.org/zap v1.27.0
15+
go.uber.org/zap/exp v0.3.0
1516
golang.org/x/crypto v0.31.0
16-
golang.org/x/net v0.29.0
17+
golang.org/x/net v0.33.0
1718
)
1819

1920
require (

go.sum

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@ github.com/caddyserver/zerossl v0.1.3 h1:onS+pxp3M8HnHpN5MMbOMyNjmTheJyWRaZYwn+Y
22
github.com/caddyserver/zerossl v0.1.3/go.mod h1:CxA0acn7oEGO6//4rtrRjYgEoa4MFw/XofZnrYwGqG4=
33
github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
44
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
5-
github.com/klauspost/cpuid/v2 v2.2.8 h1:+StwCXwm9PdpiEkPyzBXIy+M9KUb4ODm0Zarf1kS5BM=
6-
github.com/klauspost/cpuid/v2 v2.2.8/go.mod h1:Lcz8mBdAVJIBVzewtcLocK12l3Y+JytZYpaMropDUws=
5+
github.com/klauspost/cpuid/v2 v2.2.9 h1:66ze0taIn2H33fBvCkXuv9BmCwDfafmiIVpKV9kKGuY=
6+
github.com/klauspost/cpuid/v2 v2.2.9/go.mod h1:rqkxqrZ1EhYM9G+hXH7YdowN5R5RGN6NK4QwQ3WMXF8=
77
github.com/libdns/libdns v0.2.2 h1:O6ws7bAfRPaBsgAYt8MDe2HcNBGC29hkZ9MX2eUSX3s=
88
github.com/libdns/libdns v0.2.2/go.mod h1:4Bj9+5CQiNMVGf87wjX4CY3HQJypUHRuLvlsfsZqLWQ=
9-
github.com/mholt/acmez/v2 v2.0.3 h1:CgDBlEwg3QBp6s45tPQmFIBrkRIkBT4rW4orMM6p4sw=
10-
github.com/mholt/acmez/v2 v2.0.3/go.mod h1:pQ1ysaDeGrIMvJ9dfJMk5kJNkn7L2sb3UhyrX6Q91cw=
9+
github.com/mholt/acmez/v3 v3.0.0 h1:r1NcjuWR0VaKP2BTjDK9LRFBw/WvURx3jlaEUl9Ht8E=
10+
github.com/mholt/acmez/v3 v3.0.0/go.mod h1:L1wOU06KKvq7tswuMDwKdcHeKpFFgkppZy/y0DFxagQ=
1111
github.com/miekg/dns v1.1.62 h1:cN8OuEF1/x5Rq6Np+h1epln8OiyPWV+lROx9LxcGgIQ=
1212
github.com/miekg/dns v1.1.62/go.mod h1:mvDlcItzm+br7MToIKqkglaGhlFMHJ9DTNNWONWXbNQ=
1313
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
@@ -26,15 +26,16 @@ go.uber.org/multierr v1.11.0 h1:blXXJkSxSSfBVBlC76pxqeO+LN3aDfLQo+309xJstO0=
2626
go.uber.org/multierr v1.11.0/go.mod h1:20+QtiLqy0Nd6FdQB9TLXag12DsQkrbs3htMFfDN80Y=
2727
go.uber.org/zap v1.27.0 h1:aJMhYGrd5QSmlpLMr2MftRKl7t8J8PTZPA732ud/XR8=
2828
go.uber.org/zap v1.27.0/go.mod h1:GB2qFLM7cTU87MWRP2mPIjqfIDnGu+VIO4V/SdhGo2E=
29+
go.uber.org/zap/exp v0.3.0 h1:6JYzdifzYkGmTdRR59oYH+Ng7k49H9qVpWwNSsGJj3U=
30+
go.uber.org/zap/exp v0.3.0/go.mod h1:5I384qq7XGxYyByIhHm6jg5CHkGY0nsTfbDLgDDlgJQ=
2931
golang.org/x/crypto v0.31.0 h1:ihbySMvVjLAeSH1IbfcRTkD/iNscyz8rGzjF/E5hV6U=
3032
golang.org/x/crypto v0.31.0/go.mod h1:kDsLvtWBEx7MV9tJOj9bnXsPbxwJQ6csT/x4KIN4Ssk=
3133
golang.org/x/mod v0.18.0 h1:5+9lSbEzPSdWkH32vYPBwEpX8KwDbM52Ud9xBUvNlb0=
3234
golang.org/x/mod v0.18.0/go.mod h1:hTbmBsO62+eylJbnUtE2MGJUyE7QWk4xUqPFrRgJ+7c=
33-
golang.org/x/net v0.29.0 h1:5ORfpBpCs4HzDYoodCDBbwHzdR5UrLBZ3sOnUJmFoHo=
34-
golang.org/x/net v0.29.0/go.mod h1:gLkgy8jTGERgjzMic6DS9+SP0ajcu6Xu3Orq/SpETg0=
35+
golang.org/x/net v0.33.0 h1:74SYHlV8BIgHIFC/LrYkOGIwL19eTYXQ5wc6TBuO36I=
36+
golang.org/x/net v0.33.0/go.mod h1:HXLR5J+9DxmrqMwG9qjGCxZ+zKXxBru04zlTvWlWuN4=
3537
golang.org/x/sync v0.10.0 h1:3NQrjDixjgGwUOCaF8w2+VYHv0Ve/vGYSbdkTa98gmQ=
3638
golang.org/x/sync v0.10.0/go.mod h1:Czt+wKu1gCyEFDUtn0jG5QVvpJ6rzVqr5aXyt9drQfk=
37-
golang.org/x/sys v0.5.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
3839
golang.org/x/sys v0.28.0 h1:Fksou7UEQUWlKvIdsqzJmUmCX3cZuD2+P3XyyzwMhlA=
3940
golang.org/x/sys v0.28.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
4041
golang.org/x/text v0.21.0 h1:zyQAAkrwaneQ066sspRyJaG9VNi/YJ1NfzcGB3hZ/qo=

handshake.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import (
2525
"sync"
2626
"time"
2727

28-
"github.com/mholt/acmez/v2"
28+
"github.com/mholt/acmez/v3"
2929
"go.uber.org/zap"
3030
"golang.org/x/crypto/ocsp"
3131
)

0 commit comments

Comments
 (0)