Skip to content

Commit 48eb9e4

Browse files
committed
fix: address coderabbit review — Makefile bench require_binary guard
CodeRabbit flagged that the new `bench` and `bench-quick` Makefile targets skipped the `require_binary` preflight check used by every other target in this file. Added the guard plus the `@cargo` prefix to suppress command echo, matching the surrounding style. The fuller style normalization (banner echo lines, success markers) is deliberately deferred — out of scope for this review and tracked as a separate cosmetic followup. CodeRabbit-Resolved: Makefile:79:Add `require_binary` guard to new
1 parent 4119465 commit 48eb9e4

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

‎Makefile‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,10 +77,12 @@ fmt-check: ## Check code formatting
7777
@echo "$(GREEN)✓ Code formatting OK$(RESET)"
7878

7979
bench: ## Run Criterion benches (uses --features encryption)
80-
cargo bench -p cachekit-core --features encryption --bench hot_path
80+
$(call require_binary,cargo,Install Rust: https://rustup.rs)
81+
@cargo bench -p cachekit-core --features encryption --bench hot_path
8182

8283
bench-quick: ## Quick bench run for CI (1s warmup, 2s measurement, 10 samples)
83-
cargo bench -p cachekit-core --features encryption --bench hot_path -- --warm-up-time 1 --measurement-time 2 --sample-size 10
84+
$(call require_binary,cargo,Install Rust: https://rustup.rs)
85+
@cargo bench -p cachekit-core --features encryption --bench hot_path -- --warm-up-time 1 --measurement-time 2 --sample-size 10
8486

8587
fuzz-quick: ## Quick corpus-only fuzz run (2 min per target)
8688
@echo "$(BLUE)Running quick fuzzing (2 min per target)...$(RESET)"

0 commit comments

Comments
 (0)