fix: brev ls all showing all instances in org#401
Open
riac03 wants to merge 1 commit into
Open
Conversation
188d5ed to
3571d19
Compare
3571d19 to
3090b4a
Compare
3090b4a to
2769407
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
brev ls --allwas not correctly displaying all organization workspaces in the table output.Although the command is intended to show every workspace in the organization, the table rendering flow was still filtering workspaces using
FilterForUserWorkspaces, which limited the displayed instances to only those associated with the current user. As a result, organization workspaces were missing from the CLI table output even when--allwas specified.This inconsistency occurred because the JSON and table output paths used different workspace selection logic:
workspacesToShowlist.userWorkspaces, reintroducing user-level filtering into the--allflow.Solution
Updated the table rendering flow to use the same workspace selection logic as the JSON output path.
userWorkspacesfiltering from the table display flow.workspacesToShowlist when--allis enabled.This ensures that
brev ls --allconsistently displays all organization workspaces across all output modes.