Skip to content

fix: brev ls all showing all instances in org#401

Open
riac03 wants to merge 1 commit into
mainfrom
BREV-9487/brev-ls-all-fix
Open

fix: brev ls all showing all instances in org#401
riac03 wants to merge 1 commit into
mainfrom
BREV-9487/brev-ls-all-fix

Conversation

@riac03
Copy link
Copy Markdown

@riac03 riac03 commented May 20, 2026

Problem:

brev ls --all was not correctly displaying all organization workspaces in the table output.
Although the command is intended to show every workspace in the organization, the table rendering flow was still filtering workspaces using FilterForUserWorkspaces, which limited the displayed instances to only those associated with the current user. As a result, organization workspaces were missing from the CLI table output even when --all was specified.
This inconsistency occurred because the JSON and table output paths used different workspace selection logic:

  • The JSON output correctly used the full workspacesToShow list.
  • The table rendering path recalculated and reused userWorkspaces, reintroducing user-level filtering into the --all flow.

Solution

Updated the table rendering flow to use the same workspace selection logic as the JSON output path.

  • Removed the additional userWorkspaces filtering from the table display flow.
  • Ensured the table output directly uses the already computed workspacesToShow list when --all is enabled.

This ensures that brev ls --all consistently displays all organization workspaces across all output modes.

@riac03 riac03 force-pushed the BREV-9487/brev-ls-all-fix branch from 188d5ed to 3571d19 Compare May 21, 2026 02:32
@riac03 riac03 marked this pull request as ready for review May 21, 2026 02:40
@riac03 riac03 requested a review from a team as a code owner May 21, 2026 02:40
@riac03 riac03 force-pushed the BREV-9487/brev-ls-all-fix branch from 3571d19 to 3090b4a Compare May 21, 2026 03:06
@riac03 riac03 force-pushed the BREV-9487/brev-ls-all-fix branch from 3090b4a to 2769407 Compare May 21, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant