Skip to content

Fix/install script rate limit handling #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patelspratik merged 3 commits into from
Apr 23, 2026
Merged

Fix/install script rate limit handling #354

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
97a4fb8
fix: handle GitHub API rate limits in install scripts
brycelelbach Apr 8, 2026
3f4278c
review feedback + enhancements from PR 343
patelspratik Apr 13, 2026
f815d21
review feedback
patelspratik Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions bin/install-latest-linux.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,23 @@
#!/usr/bin/env bash
Copy link
Copy Markdown
Contributor

@drewmalin drewmalin Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does anything use this file anymore?

Copy link
Copy Markdown
Contributor Author

@patelspratik patelspratik Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't look like it. I'll remove.

set -eo pipefail

# Install the latest version of the Linux binary
DOWNLOAD_URL="$(curl -s https://api.github.com/repos/brevdev/brev-cli/releases/latest | grep "browser_download_url.*linux.*amd64" | cut -d '"' -f 4)"
# Fetch release metadata from GitHub API
API_RESPONSE="$(curl -sf ${GITHUB_TOKEN:+-H "Authorization: token ${GITHUB_TOKEN}"} https://api.github.com/repos/brevdev/brev-cli/releases/latest)" || {
echo "Error: Failed to fetch release info from GitHub API." >&2
echo "This is often caused by rate limiting when many requests come from the same IP." >&2
echo "If you are using a VPN, try turning it off and running this script again." >&2
echo "You can also set GITHUB_TOKEN to avoid rate limits." >&2
echo "For more details, see: https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting" >&2
exit 1
}

# Extract the download URL for linux/amd64
DOWNLOAD_URL="$(echo "${API_RESPONSE}" | grep "browser_download_url.*linux.*amd64" | cut -d '"' -f 4)"
if [ -z "${DOWNLOAD_URL}" ]; then
echo "Error: Could not find release for linux amd64" >&2
echo "GitHub API response (truncated): ${API_RESPONSE:0:200}" >&2
exit 1
fi

# Create temporary directory and ensure cleanup
TMP_DIR="$(mktemp -d)"
Expand Down
15 changes: 12 additions & 3 deletions bin/install-latest.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,21 @@ case "${ARCH}" in
aarch64) ARCH="arm64" ;;
esac

# Get the appropriate download URL for this platform
DOWNLOAD_URL="$(curl -s https://api.github.com/repos/brevdev/brev-cli/releases/latest | grep "browser_download_url.*${OS}.*${ARCH}" | cut -d '"' -f 4)"
# Fetch release metadata from GitHub API
API_RESPONSE="$(curl -sf ${GITHUB_TOKEN:+-H "Authorization: token ${GITHUB_TOKEN}"} https://api.github.com/repos/brevdev/brev-cli/releases/latest)" || {
echo "Error: Failed to fetch release info from GitHub API." >&2
echo "This is often caused by rate limiting when many requests come from the same IP." >&2
echo "If you are using a VPN, try turning it off and running this script again." >&2
echo "You can also set GITHUB_TOKEN to avoid rate limits." >&2
echo "For more details, see: https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting" >&2
exit 1
}

# Verify we found a suitable release
# Extract the download URL for this platform
DOWNLOAD_URL="$(echo "${API_RESPONSE}" | grep "browser_download_url.*${OS}.*${ARCH}" | cut -d '"' -f 4)"
Copy link
Copy Markdown
Contributor

@drewmalin drewmalin Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit of a corner case but since we have both -o pipefail (treat any command failure in a pipe as the cause of the pipefail) and -e (treat any command failure as a full script failure) if grep doesn't find the line it's looking for, which will prompt a 1 exit code from grep, then we will just fail rather than moving on to the below if-statement.

Copy link
Copy Markdown
Contributor Author

@patelspratik patelspratik Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used Claude to add a || true which should just swallow the exit code and rely on whatever DOWNLOAD_URL is to decide what to do.

if [ -z "${DOWNLOAD_URL}" ]; then
echo "Error: Could not find release for ${OS} ${ARCH}" >&2
echo "GitHub API response (truncated): ${API_RESPONSE:0:200}" >&2
exit 1
fi

Expand Down
21 changes: 15 additions & 6 deletions scripts/install-agent-skill.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,12 +116,21 @@ done
rm -rf "$TMPDIR"

# Resolve commit SHA and write .version file
COMMIT_SHA=$(curl -fsSL "https://api.github.com/repos/$REPO/commits/$BRANCH" 2>/dev/null | grep '"sha"' | head -1 | sed 's/.*"sha": *"\([^"]*\)".*/\1/')
if [[ -n "$COMMIT_SHA" ]]; then
for dir in "${INSTALL_DIRS[@]}"; do
printf 'branch=%s\ncommit=%s\n' "$BRANCH" "$COMMIT_SHA" > "$dir/.version"
done
echo -e " ${GREEN}✓${NC} .version (${COMMIT_SHA:0:12})"
VERSION_RESPONSE=$(curl -fsSL "https://api.github.com/repos/$REPO/commits/$BRANCH" 2>&1) || true
if echo "$VERSION_RESPONSE" | grep -q "API rate limit exceeded"; then
echo -e " ${YELLOW}⚠${NC} .version (skipped — GitHub API rate limit exceeded)"
echo -e " ${YELLOW}If you are using a VPN, try turning it off and running this script again.${NC}"
echo -e " ${YELLOW}See: https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting${NC}"
else
COMMIT_SHA=$(echo "$VERSION_RESPONSE" | grep '"sha"' | head -1 | sed 's/.*"sha": *"\([^"]*\)".*/\1/')
if [[ -n "$COMMIT_SHA" ]]; then
for dir in "${INSTALL_DIRS[@]}"; do
printf 'branch=%s\ncommit=%s\n' "$BRANCH" "$COMMIT_SHA" > "$dir/.version"
done
echo -e " ${GREEN}✓${NC} .version (${COMMIT_SHA:0:12})"
else
echo -e " ${YELLOW}⚠${NC} .version (could not resolve commit SHA)"
fi
fi

echo ""
Expand Down
Loading