fix: enums should be upper camel case (#5661)

Author: stuartwdouglas

jvm-runtime/ftl-runtime/common/deployment/src/main/java/xyz/block/ftl/deployment/ModuleBuilder.java

@@ -1368,14 +1368,24 @@ private Decl extractValueEnum(ClassInfo classInfo, Class<?> clazz, Visibility vi
                 valueBuilder.setStringValue(StringValue.newBuilder().setValue(aString).build());
             }
             EnumVariant variant = EnumVariant.newBuilder()
-                    .setName(constant.toString())
+                    .setName(upperSnakeToLowerCamel(constant.toString()))
                     .setValue(valueBuilder)
                     .build();
             enumBuilder.addVariants(variant);
         }
         return Decl.newBuilder().setEnum(enumBuilder).build();
     }
 
+    private static String upperSnakeToLowerCamel(String snakeStr) {
+        String[] components = snakeStr.toLowerCase().split("_");
+        StringBuilder camelCase = new StringBuilder();
+        for (var i : components) {
+            camelCase.append(i.substring(0, 1).toUpperCase())
+                    .append(i.substring(1));
+        }
+        return camelCase.toString();
+    }
+
     private record TypeEnum(Decl decl, Map<String, Class<?>> variantClasses, List<Class<?>> holders) {
     }
 

jvm-runtime/ftl-runtime/java/deployment/src/test/java/xyz/block/ftl/kotlin/deployment/test/enums/ValueEnumSchemaExtractionTest.java

@@ -29,17 +29,29 @@ public void testEnumSchema() throws Exception {
         var e = module.getDeclsList().stream().filter(Decl::hasEnum).findFirst().orElseThrow();
         Assertions.assertEquals("StringEnum", e.getEnum().getName());
         Assertions.assertEquals(2, e.getEnum().getVariantsCount());
-        Assertions.assertEquals(true, e.getEnum().getType().hasString());
+        Assertions.assertTrue(e.getEnum().getType().hasString());
+        for (var i : e.getEnum().getVariantsList()) {
+            switch (i.getName()) {
+                case "Foo":
+                    Assertions.assertEquals("foo", i.getValue().getStringValue().getValue());
+                    break;
+                case "FooBar":
+                    Assertions.assertEquals("fooBar", i.getValue().getStringValue().getValue());
+                    break;
+                default:
+                    Assertions.fail("Unexpected enum variant: " + i.getName());
+            }
+        }
     }
 
     @Verb
     public static void verb(StringEnum stringEnum) {
 
     }
 
-    public static enum StringEnum {
+    public enum StringEnum {
         FOO("foo"),
-        BAR("bar");
+        FOO_BAR("fooBar");
 
         final String value;