Fix hidden widget expectation tests#1119
Merged
jwils merged 0 commit intojoshauw/returnable-widgets-acceptancefrom Apr 11, 2026
Merged
Fix hidden widget expectation tests#1119jwils merged 0 commit intojoshauw/returnable-widgets-acceptancefrom
jwils merged 0 commit intojoshauw/returnable-widgets-acceptancefrom
Conversation
myronmarston
approved these changes
Apr 9, 2026
jwils
force-pushed
the
joshauw/fetchable-false-prototype
branch
3 times, most recently
from
335f6da to
caabea3
Compare
jwils
force-pushed
the
joshauw/returnable-widgets-schema
branch
2 times, most recently
from
cef0449 to
a2d2d8b
Compare
jwils
changed the title
returnable: false in the widgets test schema
jwils
changed the base branch from
joshauw/fetchable-false-prototype
to
joshauw/returnable-widgets-acceptance
jwils
force-pushed
the
joshauw/returnable-widgets-schema
branch
from
a2d2d8b to
041e28b
Compare
jwils
force-pushed
the
joshauw/returnable-widgets-acceptance
branch
from
81e87d8 to
c006569
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up on the widget
returnable: falseschema change by fixing the two expectations that still assumed those widget internals were visible.This branch updates:
elasticgraph-schema_definition/spec/integration/elastic_graph/schema_definition/rake_tasks_spec.rbelasticgraph-graphql/spec/acceptance/hidden_types_spec.rbTesting
bundle exec rspec elasticgraph-schema_definition/spec/integration/elastic_graph/schema_definition/rake_tasks_spec.rbbundle exec rspec elasticgraph-graphql/spec/acceptance/hidden_types_spec.rbStacked on top of #1123.