fix(config): cap http/jsonrpc maxMessageSize at Integer.MAX_VALUE

Align node.http.maxMessageSize and node.jsonrpc.maxMessageSize with the
existing node.rpc.maxMessageSize rule: reject values > Integer.MAX_VALUE
at startup with TronError. Downstream body materialization is int-bounded
(String/byte[]/StringBuilder all cap at Integer.MAX_VALUE), so config
values beyond that produced an ambiguous silent mismatch; fail-fast is
safer than a runtime NegativeArraySizeException or truncation surprise.

Update config.conf docblocks (http/rpc/jsonrpc) to state the full
constraint. Replace the obsolete 2Gi success assertion in
testMaxMessageSizeHumanReadable, add testHttpMaxMessageSizeExceedsIntMax
and testJsonRpcMaxMessageSizeExceedsIntMax mirroring the existing rpc
case.

Author: bladehan1

framework/src/main/java/org/tron/core/config/args/Args.java

@@ -536,15 +536,19 @@ public static void applyConfigParams(
     PARAMETER.httpMaxMessageSize = config.hasPath(ConfigKey.NODE_HTTP_MAX_MESSAGE_SIZE)
         ? config.getMemorySize(ConfigKey.NODE_HTTP_MAX_MESSAGE_SIZE).toBytes()
         : defaultMaxMessageSize;
-    if (PARAMETER.httpMaxMessageSize < 0) {
-      throw new TronError("node.http.maxMessageSize must be non-negative, got: "
+    if (PARAMETER.httpMaxMessageSize < 0
+        || PARAMETER.httpMaxMessageSize > Integer.MAX_VALUE) {
+      throw new TronError("node.http.maxMessageSize must be non-negative and <= "
+          + Integer.MAX_VALUE + ", got: "
           + PARAMETER.httpMaxMessageSize, PARAMETER_INIT);
     }
     PARAMETER.jsonRpcMaxMessageSize = config.hasPath(ConfigKey.NODE_JSONRPC_MAX_MESSAGE_SIZE)
         ? config.getMemorySize(ConfigKey.NODE_JSONRPC_MAX_MESSAGE_SIZE).toBytes()
         : defaultMaxMessageSize;
-    if (PARAMETER.jsonRpcMaxMessageSize < 0) {
-      throw new TronError("node.jsonrpc.maxMessageSize must be non-negative, got: "
+    if (PARAMETER.jsonRpcMaxMessageSize < 0
+        || PARAMETER.jsonRpcMaxMessageSize > Integer.MAX_VALUE) {
+      throw new TronError("node.jsonrpc.maxMessageSize must be non-negative and <= "
+          + Integer.MAX_VALUE + ", got: "
           + PARAMETER.jsonRpcMaxMessageSize, PARAMETER_INIT);
     }
 

framework/src/main/resources/config.conf

@@ -225,7 +225,8 @@ node {
     PBFTPort = 8092
 
     # The maximum request body size for HTTP API, default 4M (4194304 bytes).
-    # Supports human-readable sizes: 4m, 4MB, 4194304. Must be non-negative.
+    # Supports human-readable sizes: 4m, 4MB, 4194304.
+    # Must be non-negative and <= 2147483647 (Integer.MAX_VALUE, ~2 GiB).
     # Setting to 0 rejects all non-empty request bodies (not "unlimited").
     # maxMessageSize = 4m
   }
@@ -254,7 +255,8 @@ node {
     # maxConnectionAgeInMillis =
 
     # The maximum message size allowed to be received on the server, default 4M (4194304 bytes).
-    # Supports human-readable sizes: 4m, 4MB, 4194304. Must be non-negative.
+    # Supports human-readable sizes: 4m, 4MB, 4194304.
+    # Must be non-negative and <= 2147483647 (Integer.MAX_VALUE, ~2 GiB).
     # Setting to 0 rejects all non-empty request bodies (not "unlimited").
     # maxMessageSize = 4m
 
@@ -365,7 +367,8 @@ node {
 
   jsonrpc {
     # The maximum request body size for JSON-RPC API, default 4M (4194304 bytes).
-    # Supports human-readable sizes: 4m, 4MB, 4194304. Must be non-negative.
+    # Supports human-readable sizes: 4m, 4MB, 4194304.
+    # Must be non-negative and <= 2147483647 (Integer.MAX_VALUE, ~2 GiB).
     # Setting to 0 rejects all non-empty request bodies (not "unlimited").
     # maxMessageSize = 4m
 

framework/src/test/java/org/tron/core/config/args/ArgsTest.java

@@ -417,7 +417,7 @@ public void testMaxMessageSizeHumanReadable() {
     Args.clearParam();
 
     // --- GB tier: binary (g/G/Gi/GiB) vs SI (GB) ---
-    // rpc is int-bounded, only test http/jsonrpc for GB values
+    // All three paths are int-bounded; values up to Integer.MAX_VALUE are accepted.
     configMap.put("node.rpc.maxMessageSize", "4m");
     configMap.put("node.http.maxMessageSize", "1g");
     configMap.put("node.jsonrpc.maxMessageSize", "1GB");
@@ -429,17 +429,6 @@ public void testMaxMessageSizeHumanReadable() {
     Assert.assertEquals(1000L * 1000 * 1000, Args.getInstance().getJsonRpcMaxMessageSize());
     Args.clearParam();
 
-    configMap.put("node.rpc.maxMessageSize", "4m");
-    configMap.put("node.http.maxMessageSize", "2Gi");
-    configMap.put("node.jsonrpc.maxMessageSize", "2GiB");
-    config = ConfigFactory.defaultOverrides()
-        .withFallback(ConfigFactory.parseMap(configMap));
-    Args.applyConfigParams(config);
-    Assert.assertEquals(4 * 1024 * 1024, Args.getInstance().getMaxMessageSize());
-    Assert.assertEquals(2L * 1024 * 1024 * 1024, Args.getInstance().getHttpMaxMessageSize());
-    Assert.assertEquals(2L * 1024 * 1024 * 1024, Args.getInstance().getJsonRpcMaxMessageSize());
-    Args.clearParam();
-
     // --- raw integer (backward compatible): treated as bytes ---
     configMap.put("node.rpc.maxMessageSize", "4194304");
     configMap.put("node.http.maxMessageSize", "4194304");
@@ -477,6 +466,31 @@ public void testRpcMaxMessageSizeExceedsIntMax() {
     Assert.assertTrue(e.getMessage().contains("node.rpc.maxMessageSize must be non-negative"));
   }
 
+  @Test
+  public void testHttpMaxMessageSizeExceedsIntMax() {
+    Map<String, String> configMap = new HashMap<>();
+    configMap.put("storage.db.directory", "database");
+    configMap.put("node.http.maxMessageSize", "2Gi");
+    Config config = ConfigFactory.defaultOverrides()
+        .withFallback(ConfigFactory.parseMap(configMap));
+    TronError e = Assert.assertThrows(TronError.class,
+        () -> Args.applyConfigParams(config));
+    Assert.assertTrue(e.getMessage().contains("node.http.maxMessageSize must be non-negative"));
+  }
+
+  @Test
+  public void testJsonRpcMaxMessageSizeExceedsIntMax() {
+    Map<String, String> configMap = new HashMap<>();
+    configMap.put("storage.db.directory", "database");
+    configMap.put("node.jsonrpc.maxMessageSize", "2Gi");
+    Config config = ConfigFactory.defaultOverrides()
+        .withFallback(ConfigFactory.parseMap(configMap));
+    TronError e = Assert.assertThrows(TronError.class,
+        () -> Args.applyConfigParams(config));
+    Assert.assertTrue(
+        e.getMessage().contains("node.jsonrpc.maxMessageSize must be non-negative"));
+  }
+
   @Test
   public void testMaxMessageSizeNegativeValue() {
     Map<String, String> configMap = new HashMap<>();