Skip to content

Commit a20e9bd

Browse files
committed
Do not use mutable objects as default arguments.
REF: http://docs.python-guide.org/en/latest/writing/gotchas/
1 parent 30104f1 commit a20e9bd

1 file changed

Lines changed: 8 additions & 3 deletions

File tree

bigcommerce/connection.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,12 @@ def __init__(self, host, auth, api_path='/api/v2/{}'):
4444
def full_path(self, url):
4545
return "https://" + self.host + self.api_path.format(url)
4646

47-
def _run_method(self, method, url, data=None, query={}, headers={}):
47+
def _run_method(self, method, url, data=None, query=None, headers=None):
48+
if query is None:
49+
query = {}
50+
if headers is None:
51+
headers = {}
52+
4853
# make full path if not given
4954
if url and url[:4] != "http":
5055
if url[0] == '/': # can call with /resource if you want
@@ -118,7 +123,7 @@ def delete(self, resource, rid=None): # note that rid can't be 0 - problem?
118123

119124
# Raw-er stuff
120125

121-
def make_request(self, method, url, data=None, params = {}, headers = {}):
126+
def make_request(self, method, url, data=None, params=None, headers=None):
122127
response = self._run_method(method, url, data, params, headers)
123128
return self._handle_response(url, response)
124129

@@ -249,4 +254,4 @@ def _handle_response(self, url, res, suppress_empty=True):
249254
window_size_ms=res.headers['X-Rate-Limit-Time-Window-Ms'],
250255
requests_remaining=res.headers['X-Rate-Limit-Requests-Left'],
251256
requests_quota=res.headers['X-Rate-Limit-Requests-Quota'])
252-
return result
257+
return result

0 commit comments

Comments
 (0)