Skip to content

Commit 5235dd6

Browse files
nmadanNamrata Madan
andauthored
Update remote function serialization/deserialization logic to use asymmetric keys for data verification checks (#5708)
* Revert "Bug fix for hmac key for V3 (#5379)" This reverts commit fb0d789. * Revert "Add sagemaker dependency for remote function by default V3 (#5487)" This reverts commit 422b35f. * fix: use asymmetric keys to sign remote function signature * chore: migrate remote_function integ tests from V2 * fix: rename signing key --------- Co-authored-by: Namrata Madan <nmmadan@amazon.com>
1 parent 6558d01 commit 5235dd6

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+2652
-2564
lines changed

requirements/extras/test_requirements.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,6 @@ omegaconf
1212
graphene
1313
typing_extensions>=4.9.0
1414
tensorflow>=2.16.2,<=2.19.0
15-
build
15+
build
16+
docker>=5.0.2,<8.0
17+
filelock>=3.0.0

sagemaker-core/pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ dependencies = [
3838
"cloudpickle>=2.0.0",
3939
"paramiko>=2.11.0",
4040
"tblib>=1.7.0",
41+
"cryptography>=46.0.0",
4142
]
4243
requires-python = ">=3.9"
4344
classifiers = [

sagemaker-core/src/sagemaker/core/remote_function/client.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -369,7 +369,6 @@ def wrapper(*args, **kwargs):
369369
s3_uri=s3_path_join(
370370
job_settings.s3_root_uri, job.job_name, EXCEPTION_FOLDER
371371
),
372-
373372
)
374373
except ServiceError as serr:
375374
chained_e = serr.__cause__
@@ -406,7 +405,6 @@ def wrapper(*args, **kwargs):
406405
return serialization.deserialize_obj_from_s3(
407406
sagemaker_session=job_settings.sagemaker_session,
408407
s3_uri=s3_path_join(job_settings.s3_root_uri, job.job_name, RESULTS_FOLDER),
409-
410408
)
411409

412410
if job.describe()["TrainingJobStatus"] == "Stopped":
@@ -1008,7 +1006,6 @@ def from_describe_response(describe_training_job_response, sagemaker_session):
10081006
job_return = serialization.deserialize_obj_from_s3(
10091007
sagemaker_session=sagemaker_session,
10101008
s3_uri=s3_path_join(job.s3_uri, RESULTS_FOLDER),
1011-
10121009
)
10131010
except DeserializationError as e:
10141011
client_exception = e
@@ -1020,7 +1017,6 @@ def from_describe_response(describe_training_job_response, sagemaker_session):
10201017
job_exception = serialization.deserialize_exception_from_s3(
10211018
sagemaker_session=sagemaker_session,
10221019
s3_uri=s3_path_join(job.s3_uri, EXCEPTION_FOLDER),
1023-
10241020
)
10251021
except ServiceError as serr:
10261022
chained_e = serr.__cause__
@@ -1110,7 +1106,6 @@ def result(self, timeout: float = None) -> Any:
11101106
self._return = serialization.deserialize_obj_from_s3(
11111107
sagemaker_session=self._job.sagemaker_session,
11121108
s3_uri=s3_path_join(self._job.s3_uri, RESULTS_FOLDER),
1113-
11141109
)
11151110
self._state = _FINISHED
11161111
return self._return
@@ -1119,7 +1114,6 @@ def result(self, timeout: float = None) -> Any:
11191114
self._exception = serialization.deserialize_exception_from_s3(
11201115
sagemaker_session=self._job.sagemaker_session,
11211116
s3_uri=s3_path_join(self._job.s3_uri, EXCEPTION_FOLDER),
1122-
11231117
)
11241118
except ServiceError as serr:
11251119
chained_e = serr.__cause__

0 commit comments

Comments
 (0)