sae: Introduce cross-chain tx gossip#5408
Open
StephenButtolph wants to merge 12 commits into
Open
Conversation
StephenButtolph
force-pushed
the
StephenButtolph/sae-gossip
branch
from
06e0c94 to
096e134
Compare
StephenButtolph
force-pushed
the
StephenButtolph/sae-gossip
branch
from
0903cbc to
6c3969e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR factors out cross-chain tx gossip from the SAE PoC #5303.
How this works
This PR implements the gossip system, to enable pushing/pulling transactions to/from peers. Additionally, it marks transactions sent over the RPC as push-able.
Rather than exposing addition exported functions from the
txpoolandtxpackages, this PR implemented minimal unexported wrappers.Most other VMs will re-inject transactions included in a rejected block back into the txpool (which was originally in the SAE PoC), but that behavior doesn't really make a ton of sense for SAE. The transactions stay in the txpool until they are executed (or replaced), so we don't need to re-add them back into the txpool during rejection, they shouldn't have been removed yet anyways.
Additionally, as part of testing, I needed to again wire multiple SUTs together for gossip. This was something that was already done in SAE, so I made a shareable helper that both implementations could use.
How this was tested
Need to be documented in RELEASES.md?
No