address feedback

Author: jimmyyan9

.circleci/config.yml

@@ -26,22 +26,17 @@ jobs:
     docker:
       - image: cimg/node:lts
     environment:
-      - AUTH0_CFG: Sample-01/src/auth_config.json
       - SAMPLE_PATH: Sample-01
     steps:
       - node/install
       - attach_workspace:
           at: ~/
-      - run:
-          name: Replace Auth0 test credentials
-          command: |
-            echo "{ \"domain\": \"$AUTH0_TEST_DOMAIN\", \"clientId\": \"$AUTH0_TEST_CLIENT_ID\", \"audience\": \"$AUTH0_TEST_API_IDENTIFIER\" }" > $AUTH0_CFG
       - setup_remote_docker:
           version: 19.03.13
       - run:
           name: Build pull request
           command: |
-            docker build -t $CIRCLE_JOB ./$SAMPLE_PATH
+            docker build --build-arg AUTH0_DOMAIN=$AUTH0_TEST_DOMAIN --build-arg AUTH0_CLIENT_ID=$AUTH0_TEST_CLIENT_ID --build-arg AUTH0_AUDIENCE=$AUTH0_TEST_API_IDENTIFIER -t $CIRCLE_JOB ./$SAMPLE_PATH
             docker run -d -p 3000:3000 --name $CIRCLE_SHA1 $CIRCLE_JOB
       - run:
           name: Wait for app to be available

Sample-01/.env.example

@@ -3,4 +3,4 @@ AUTH0_CLIENT_ID={yourClientId}
 # AUTH0_AUDIENCE={yourApiIdentifier}
 
 # APP_BASE_URL=https://your-app.com
-# API_BASE_URL=https://your-api-server.com
+# API_BASE_URL=https://your-api-server.com

Sample-01/README.md

@@ -1,6 +1,6 @@
 # Auth0 React SDK Sample Application
 
-This sample demonstrates the integration of [Auth0 React SDK](https://github.com/auth0/auth0-react) into a React application created using [Vite](https://reactjs.org/docs/create-a-new-react-app.html). The sample is a companion to the [Auth0 React SDK Quickstart](https://auth0.com/docs/quickstart/spa/react).
+This sample demonstrates the integration of [Auth0 React SDK](https://github.com/auth0/auth0-react) into a React application created using [Vite](https://vite.dev). The sample is a companion to the [Auth0 React SDK Quickstart](https://auth0.com/docs/quickstart/spa/react).
 
 This sample demonstrates the following use cases:
 

Sample-01/exec.ps1

@@ -16,4 +16,4 @@ docker build `
     --build-arg "API_BASE_URL=$($envVars['API_BASE_URL'])" `
     -t auth0-react-01-login .
 
-docker run --init -p 3000:3000 -p 3001:3001 --env-file .env.local -it auth0-react-01-login
+docker run --init -p 3000:3000 -p 3001:3001 --env-file .env.local -it auth0-react-01-login

Sample-01/exec.sh

@@ -4,7 +4,10 @@ if [ ! -f .env.local ]; then
   exit 1
 fi
 
-export $(grep -v '^#' .env.local | grep -v '^$' | xargs)
+AUTH0_DOMAIN=$(grep '^AUTH0_DOMAIN=' .env.local | cut -d '=' -f2-)
+AUTH0_CLIENT_ID=$(grep '^AUTH0_CLIENT_ID=' .env.local | cut -d '=' -f2-)
+AUTH0_AUDIENCE=$(grep '^AUTH0_AUDIENCE=' .env.local | cut -d '=' -f2-)
+API_BASE_URL=$(grep '^API_BASE_URL=' .env.local | cut -d '=' -f2-)
 
 docker build \
   --build-arg AUTH0_DOMAIN="$AUTH0_DOMAIN" \
@@ -13,4 +16,4 @@ docker build \
   --build-arg API_BASE_URL="$API_BASE_URL" \
   -t auth0-react-02-calling-an-api .
 
-docker run --init -p 3000:3000 -p 3001:3001 --env-file .env.local -it auth0-react-02-calling-an-api
+docker run --init -p 3000:3000 -p 3001:3001 --env-file .env.local -it auth0-react-02-calling-an-api

Sample-01/package-lock.json

@@ -32,7 +32,7 @@
     "react": "^19.2.4",
     "react-bootstrap": "2.10.10",
     "react-dom": "^19.2.4",
-    "react-router-dom": "^6.3",
+    "react-router-dom": "^6",
     "vite": "^8.0.3"
   },
   "devDependencies": {