fix: address PR review feedback round 4

- Add max batch size (1000) validation for apply-batch and dismiss-batch
- Convert correlated subqueries to JOINs in getPersonsWithPlaces
- Add error handling for SSE geocode stream with error event to client

Author: atomantic

server/src/routes/ai-discovery.routes.ts

@@ -107,6 +107,10 @@ router.post('/:dbId/apply-batch', async (req: Request, res: Response) => {
     res.status(400).json({ success: false, error: 'candidates array is required' });
     return;
   }
+  if (candidates.length > 1000) {
+    res.status(400).json({ success: false, error: 'Maximum 1000 candidates per batch' });
+    return;
+  }
 
   let applied = 0;
   for (const candidate of candidates) {
@@ -159,6 +163,10 @@ router.post('/:dbId/dismiss-batch', async (req: Request, res: Response) => {
     res.status(400).json({ success: false, error: 'candidates array is required' });
     return;
   }
+  if (candidates.length > 1000) {
+    res.status(400).json({ success: false, error: 'Maximum 1000 candidates per batch' });
+    return;
+  }
 
   const result = aiDiscoveryService.dismissCandidatesBatch(dbId, candidates);
   res.json({ success: true, data: result });

server/src/routes/map.routes.ts

@@ -79,12 +79,21 @@ mapRouter.get('/geocode/stream', async (req: Request, res: Response) => {
   let cancelled = false;
   req.on('close', () => { cancelled = true; });
 
-  for await (const progress of geocodeService.batchGeocode(placesToGeocode)) {
-    if (cancelled) break;
-    res.write(`data: ${JSON.stringify(progress)}\n\n`);
-  }
-
-  if (!cancelled) {
+  const streamResult = await (async () => {
+    for await (const progress of geocodeService.batchGeocode(placesToGeocode)) {
+      if (cancelled) return 'cancelled';
+      res.write(`data: ${JSON.stringify(progress)}\n\n`);
+    }
+    return 'ok';
+  })().catch((err: Error) => {
+    logger.api('map', `❌ Batch geocode stream error: ${err.message}`);
+    if (!cancelled) {
+      res.write(`data: ${JSON.stringify({ type: 'error', message: err.message })}\n\n`);
+    }
+    return 'error';
+  });
+
+  if (streamResult === 'ok') {
     res.write(`data: ${JSON.stringify({ type: 'complete', current: placesToGeocode.length, total: placesToGeocode.length })}\n\n`);
   }
 

server/src/services/map.service.ts

@@ -46,12 +46,13 @@ function getPersonsWithPlaces(personIds: string[]): Map<string, {
       death_year: number | null;
     }>(
       `SELECT p.person_id, p.display_name, p.gender,
-        (SELECT place FROM vital_event WHERE person_id = p.person_id AND event_type = 'birth' LIMIT 1) as birth_place,
-        (SELECT date_year FROM vital_event WHERE person_id = p.person_id AND event_type = 'birth' LIMIT 1) as birth_year,
-        (SELECT place FROM vital_event WHERE person_id = p.person_id AND event_type = 'death' LIMIT 1) as death_place,
-        (SELECT date_year FROM vital_event WHERE person_id = p.person_id AND event_type = 'death' LIMIT 1) as death_year
+        vb.place AS birth_place, vb.date_year AS birth_year,
+        vd.place AS death_place, vd.date_year AS death_year
        FROM person p
-       WHERE p.person_id IN (${placeholders})`,
+       LEFT JOIN vital_event vb ON vb.person_id = p.person_id AND vb.event_type = 'birth'
+       LEFT JOIN vital_event vd ON vd.person_id = p.person_id AND vd.event_type = 'death'
+       WHERE p.person_id IN (${placeholders})
+       GROUP BY p.person_id`,
       params
     );