Repository navigation
Conversation
The Python test matrix only ever ran 3.12, because .python-version made uv sync ignore the matrix value, and nothing tested any Airflow version but the one in uv.lock. Unit tests now run on each supported Python and Airflow pair, with Airflow installed from its constraints file. The integration tests run on one Astro Runtime image per Airflow minor, after a Blueprint Maintainer approves the run. The new matrix found these bugs: - Python 3.10 crashed on set[...] and tuple[...] config fields, and rejected self-referencing models such as list["TreeNode"]. - click 8.3.0 and 8.3.1 break `blueprint schema --dag-args`. Airflow 2.11 and 3.1 pin 8.3.1. The Airflow floor moves to 2.10, since the pydantic>=2.10.6 pin already blocked constrained installs of anything older.
|
Claude finished @jlaneve's task in 3m 33s —— View job PR Review: Test against every supported Airflow and Python version
|
…hs on timeout A future pydantic that removes the private unpack_lenient_weakvaluedict should cost only forward-ref lookups in local scope, not break import blueprint for every user.
|
took 1 and 4 in 9015ea7: the pydantic import now falls back to no lookup instead of breaking skipping the rest:
|
|
Claude finished @jlaneve's task in 2m 6s —— View job PR Review: Test against every supported Airflow and Python version
The two fixes from Items addressedPydantic fallback ( **(unpack_lenient_weakvaluedict(model.__pydantic_parent_namespace__) or {}),The fallback returns Health timeout message ( paths = ", ".join(HEALTH_PATHS.values())
msg = f"Airflow did not become healthy within {HEALTH_CHECK_TIMEOUT}s at {base_url} ({paths})"Clear and includes both probed paths. Done. Responses to skipped items confirmed correct
Python 3.12 pin in One new observation
The Architectural notes (looks good)
Overall this is a well-executed PR. The matrix architecture is sound, the Python 3.10 fixes are correct, and the integration test gating is appropriately conservative. |

The test matrix only ever ran Python 3.12 against the Airflow version in
uv.lock..python-versionmadeuv syncignore the matrix value, so the "3.10" job on main ranPython 3.12.3. Unit tests now run on each supported pair of Python 3.10–3.14 and Airflow 2.10–3.3. The integration suite runs on one Astro Runtime image per Airflow minor.The integration tests start only after a Blueprint Maintainer approves the run in the new
integrationenvironment.integration-testis still a required check, so every PR needs that approval before it can merge.Call-stack diff
Unchanged: lint, the publish steps in
release.yml, and the names of the required checks.set[...]andtuple[...]config fields and rejected forward references such aslist["Item"]. Also, click 8.3.0 and 8.3.1 breakblueprint schema --dag-args, and Airflow 2.11 and 3.1 pin 8.3.1. This PR fixes all of these and excludes those two click releases.pydantic>=2.10.6pin already blocked constrained installs of any older Airflow.install-airflow.shdrops our dev tools from Airflow's constraints file, plus any pin that our own requirements forbid. Each job then tests what a user's pip would resolve. The Airflow 2.10 job still runs at the pydantic floor._resolve_forward_refsreads local classes through pydantic's privateunpack_lenient_weakvaluedict. The function exists from 2.10.6 through 2.13, and the matrix tests both ends.