fix: Don't remove project.dependencies when deps groups are present#1284
Draft
konsti-openai wants to merge 1 commit into
Draft
fix: Don't remove project.dependencies when deps groups are present#1284konsti-openai wants to merge 1 commit into
project.dependencies when deps groups are present#1284konsti-openai wants to merge 1 commit into
Conversation
Currently, `project.dependencies` are removed from consideration where the first dep group is added. This shouldn't happen, as dependency groups are additive, and `project.dependencies` are intended as the main production dependencies.
|
|
konsti-openai
changed the title
project.dependencies when deps groups are presentproject.dependencies when deps groups are present
konsti-openai
changed the title
project.dependencies when deps groups are presentproject.dependencies when deps groups are present
Member
|
This looks valuable, but I would like to see and e2e that demostrate the feature |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
project.dependenciesare removed from consideration where the first dep group is added. This shouldn't happen, as dependency groups are additive, andproject.dependenciesare intended as the main production dependencies.Changes are visible to end-users: yes
Test plan