From d8959e0f4d17c111092e3bef75a80614218171f7 Mon Sep 17 00:00:00 2001 From: wei Date: Mon, 6 Jul 2026 19:11:18 +0800 Subject: [PATCH] fix(postgresql): remove static IMAGE_TAG fallback that hid version-mapping misses MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Four ActionSets defaulted IMAGE_TAG to 14.8.0-pgvector-v0.6.1. The BPT's per-method versionMapping overrides it for every serviceVersion declared in the chart, so the default only ever fired on a mapping miss (e.g. a custom ComponentVersion minor) — silently running a PG 16/17/18 cluster's backup/restore tooling with the PG 14 image. The defaults are removed; on a miss the image now renders with a literal $(IMAGE_TAG) tag and the job fails visibly at image resolution, naming the unexpanded variable. pgdumpall's env block became empty and is dropped. wal-g / wal-g-incremental are unaffected (fixed walgImage helper, no IMAGE_TAG). Fixes #3062 Co-Authored-By: Claude Fable 5 --- addons/postgresql/templates/actionset-pgbasebackup.yaml | 2 -- addons/postgresql/templates/actionset-pgdumpall.yaml | 3 --- addons/postgresql/templates/actionset-postgresql-pitr.yaml | 2 -- addons/postgresql/templates/actionset-wal-g-pitr.yaml | 2 -- 4 files changed, 9 deletions(-) diff --git a/addons/postgresql/templates/actionset-pgbasebackup.yaml b/addons/postgresql/templates/actionset-pgbasebackup.yaml index c5ca7239e8..3c55e02fb2 100644 --- a/addons/postgresql/templates/actionset-pgbasebackup.yaml +++ b/addons/postgresql/templates/actionset-pgbasebackup.yaml @@ -10,8 +10,6 @@ spec: env: - name: DATA_DIR value: {{ .Values.dataMountPath }}/pgroot/data - - name: IMAGE_TAG - value: 14.8.0-pgvector-v0.6.1 backup: preBackup: [] postBackup: [] diff --git a/addons/postgresql/templates/actionset-pgdumpall.yaml b/addons/postgresql/templates/actionset-pgdumpall.yaml index ee9c09e92a..4f76d39106 100644 --- a/addons/postgresql/templates/actionset-pgdumpall.yaml +++ b/addons/postgresql/templates/actionset-pgdumpall.yaml @@ -7,9 +7,6 @@ metadata: {{- include "postgresql.labels" . | nindent 4 }} spec: backupType: Selective - env: - - name: IMAGE_TAG - value: 14.8.0-pgvector-v0.6.1 parametersSchema: openAPIV3Schema: type: object diff --git a/addons/postgresql/templates/actionset-postgresql-pitr.yaml b/addons/postgresql/templates/actionset-postgresql-pitr.yaml index 6ccccbc48d..c6df5bb3aa 100644 --- a/addons/postgresql/templates/actionset-postgresql-pitr.yaml +++ b/addons/postgresql/templates/actionset-postgresql-pitr.yaml @@ -28,8 +28,6 @@ spec: value: "3" - name: SWITCH_WAL_INTERVAL_SECONDS value: "600" - - name: IMAGE_TAG - value: 14.8.0-pgvector-v0.6.1 restore: prepareData: image: {{ .Values.image.registry | default "docker.io" }}/{{ .Values.image.repository }}:$(IMAGE_TAG) diff --git a/addons/postgresql/templates/actionset-wal-g-pitr.yaml b/addons/postgresql/templates/actionset-wal-g-pitr.yaml index 44d7c76be1..cf5d6d2835 100644 --- a/addons/postgresql/templates/actionset-wal-g-pitr.yaml +++ b/addons/postgresql/templates/actionset-wal-g-pitr.yaml @@ -20,8 +20,6 @@ spec: value: $(VOLUME_DATA_DIR)/pgroot/data/pg_wal - name: LOG_ARCHIVE_SECONDS value: "5" - - name: IMAGE_TAG - value: 14.8.0-pgvector-v0.6.1 - name: TARGET_POD_ROLE # TODO input by backup policy value: primary