THRIFT-6015: Add Ruby multiplexed default processor#3504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the default fallback service capability to multiplex processors as discussed after introducing the multiplex protocol in THRIFT-1915.
This functionality is already present in Java, C++, Python, Go, Rust, Swift, Perl, Haxe, C GLib (but seem to be missing from NodeJS, .NET, PHP). It is also being tested by
multi*family in cross-tests.Additionally, I removed the separate group for Ruby from cross-tests, as with UUID support implemented a while ago it is not longer needed.
[skip ci]anywhere in the commit message to free up build resources.