KAFKA-18209: Clean up transaction state topic config logic#22456
Merged
Conversation
github-actions
Bot
added
triage
Contributor
Author
|
Hi @mimaison , would you mind reviewing this PR when you have a chance? |
chia7712
reviewed
Jun 6, 2026
| * @return the transactional id | ||
| * @throws IllegalStateException if the version is not a valid transaction log key version | ||
| */ | ||
| public static String readTxnRecordKey(ByteBuffer buffer) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up the
__transaction_statetopic config logic byremoving scattered configuration related constants from
TransactionLogand keeping it focused on serialization/deserialization.
It also moves transaction state topic config construction to
TransactionCoordinatorand renamestransactionTopicConfigstotransactionStateTopicConfigsfor clarity, aligning with the currentgroup/share coordinator pattern where coordinators expose internal topic
configs to the broker.
Reviewers: Chia-Ping Tsai chia7712@gmail.com