Update BucketCache initialization in TestVerifyBucketCacheFile to include DEFAULT_ERROR_TOLERATION_DURATION and configuration parameters. This change enhances error handling and ensures consistent cache restoration behavior during tests.

Author: sairampola

hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestVerifyBucketCacheFile.java

@@ -103,9 +103,9 @@ public void testRetrieveFromFile() throws Exception {
     BucketCache bucketCache = null;
     BucketCache recoveredBucketCache = null;
     try {
-      bucketCache =
-        new BucketCache("file:" + testDir + "/bucket.cache", capacitySize, constructedBlockSize,
-          constructedBlockSizes, writeThreads, writerQLen, testDir + "/bucket.persistence");
+      bucketCache = new BucketCache("file:" + testDir + "/bucket.cache", capacitySize,
+        constructedBlockSize, constructedBlockSizes, writeThreads, writerQLen,
+        testDir + "/bucket.persistence", DEFAULT_ERROR_TOLERATION_DURATION, conf);
       assertTrue(bucketCache.waitForCacheInitialization(10000));
       long usedSize = bucketCache.getAllocator().getUsedSize();
       assertEquals(0, usedSize);
@@ -121,9 +121,9 @@ public void testRetrieveFromFile() throws Exception {
       // 1.persist cache to file
       bucketCache.shutdown();
       // restore cache from file
-      bucketCache =
-        new BucketCache("file:" + testDir + "/bucket.cache", capacitySize, constructedBlockSize,
-          constructedBlockSizes, writeThreads, writerQLen, testDir + "/bucket.persistence");
+      bucketCache = new BucketCache("file:" + testDir + "/bucket.cache", capacitySize,
+        constructedBlockSize, constructedBlockSizes, writeThreads, writerQLen,
+        testDir + "/bucket.persistence", DEFAULT_ERROR_TOLERATION_DURATION, conf);
       assertTrue(bucketCache.waitForCacheInitialization(10000));
       assertEquals(usedSize, bucketCache.getAllocator().getUsedSize());
       // persist cache to file
@@ -134,9 +134,9 @@ public void testRetrieveFromFile() throws Exception {
         FileSystems.getDefault().getPath(testDir.toString(), "bucket.cache");
       assertTrue(Files.deleteIfExists(cacheFile));
       // can't restore cache from file
-      recoveredBucketCache =
-        new BucketCache("file:" + testDir + "/bucket.cache", capacitySize, constructedBlockSize,
-          constructedBlockSizes, writeThreads, writerQLen, testDir + "/bucket.persistence");
+      recoveredBucketCache = new BucketCache("file:" + testDir + "/bucket.cache", capacitySize,
+        constructedBlockSize, constructedBlockSizes, writeThreads, writerQLen,
+        testDir + "/bucket.persistence", DEFAULT_ERROR_TOLERATION_DURATION, conf);
       assertTrue(recoveredBucketCache.waitForCacheInitialization(10000));
       waitPersistentCacheValidation(conf, recoveredBucketCache);
       assertEquals(0, recoveredBucketCache.getAllocator().getUsedSize());