fix: support SQL date types in WriteCellData#912
Open
skytin1004 wants to merge 2 commits into
Open
Conversation
skytin1004
force-pushed
the
fix/714-support-sql-date-types-write-cell-data
branch
from
7ec9fe2 to
6d774c2
Compare
alaahong
reviewed
May 18, 2026
| this.dateValue = LocalDateTime.ofInstant(Instant.ofEpochMilli(dateValue.getTime()), ZoneId.systemDefault()); | ||
| } else { | ||
| this.dateValue = LocalDateTime.ofInstant(dateValue.toInstant(), ZoneId.systemDefault()); | ||
| } |
Member
There was a problem hiding this comment.
is any time zone issue here? seems depends on the execution machine
Contributor
Author
There was a problem hiding this comment.
@alaahong Good point. I changed this path to use SQL Date/Time APIs directly instead of going through epoch millis.
java.sql.Date now uses toLocalDate(), and java.sql.Time uses toLocalTime(). The existing toInstant() path is still kept for java.util.Date and java.sql.Timestamp.
I also checked the other date conversions. Some existing generic Date/Calendar paths still use the system default timezone, but they are not introduced by this PR. I will look at those separately and follow up if we want to make them consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Closed: #714
I've fixed
WriteCellData(Date)when the actual value isjava.sql.Dateorjava.sql.Time.I reproduced the failure locally and confirmed that both SQL date/time types can throw
UnsupportedOperationExceptionwhentoInstant()is called directly.What's changed?
The existing
toInstant()path is kept forjava.util.Dateandjava.sql.Timestamp. This keeps the behavior unchanged for regular date values and preservesjava.sql.Timestampnano precision.I added regression tests for:
java.sql.Datejava.sql.Timejava.sql.TimestampTo verify the fix, I first confirmed that the new
WriteCellDataTestfailed before the change withUnsupportedOperationExceptionfromjava.sql.Date.toInstant()andjava.sql.Time.toInstant(). After applying the fix, I confirmed that the new test passed, the existing relatedCellDataDataTestpassed together with it, and the fullfesod-sheettest suite also passed.Checklist