Add affinity type constants and use them to fix cross-plugin compilation error

Author: Daman Arora

api/src/main/java/org/apache/cloudstack/affinity/AffinityProcessorBase.java

@@ -29,6 +29,9 @@
 
 public class AffinityProcessorBase extends AdapterBase implements AffinityGroupProcessor {
 
+    public static final String AFFINITY_TYPE_HOST = "host affinity";
+    public static final String AFFINITY_TYPE_HOST_ANTI = "host anti-affinity";
+
     protected String _type;
 
     @Override

plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java

@@ -59,8 +59,7 @@
 import org.apache.cloudstack.affinity.AffinityGroupProcessor;
 import org.apache.cloudstack.affinity.AffinityGroupService;
 import org.apache.cloudstack.affinity.AffinityGroupVO;
-import org.apache.cloudstack.affinity.HostAffinityProcessor;
-import org.apache.cloudstack.affinity.HostAntiAffinityProcessor;
+import org.apache.cloudstack.affinity.AffinityProcessorBase;
 import org.apache.cloudstack.affinity.dao.AffinityGroupDao;
 import org.apache.cloudstack.affinity.dao.AffinityGroupVMMapDao;
 import org.apache.cloudstack.annotation.AnnotationService;
@@ -2579,14 +2578,14 @@ protected void validateNodesAgainstExistingWorkers(List<Long> nodeIds, Set<Long>
             Long nodeHostId = node.getHostId();
             String nodeHostName = getHostName(nodeHostId);
 
-            if (processor instanceof HostAntiAffinityProcessor) {
+            if (AffinityProcessorBase.AFFINITY_TYPE_HOST_ANTI.equals(affinityGroup.getType())) {
                 if (existingWorkerHostIds.contains(nodeHostId)) {
                     throw new InvalidParameterValueException(String.format(
                             "Cannot add VM %s to cluster %s. VM is running on host %s which violates the cluster's " +
                             "host anti-affinity rule (affinity group: %s). Existing worker VMs are already running on this host.",
                             node.getInstanceName(), cluster.getName(), nodeHostName, affinityGroup.getName()));
                 }
-            } else if (processor instanceof HostAffinityProcessor) {
+            } else if (AffinityProcessorBase.AFFINITY_TYPE_HOST.equals(affinityGroup.getType())) {
                 if (!existingWorkerHostIds.isEmpty() && !existingWorkerHostIds.contains(nodeHostId)) {
                     List<String> existingHostNames = existingWorkerHostIds.stream()
                             .map(this::getHostName)
@@ -2604,7 +2603,7 @@ protected void validateNodesAgainstExistingWorkers(List<Long> nodeIds, Set<Long>
 
     protected void validateNewNodesAntiAffinity(List<Long> nodeIds, AffinityGroupVO affinityGroup, KubernetesCluster cluster) {
         AffinityGroupProcessor processor = getAffinityGroupProcessor(affinityGroup.getType());
-        if (!(processor instanceof HostAntiAffinityProcessor)) {
+        if (processor == null || !AffinityProcessorBase.AFFINITY_TYPE_HOST_ANTI.equals(affinityGroup.getType())) {
             return;
         }