From 9ecc97f3b46adf4420502531a65a3d7c18794b0d Mon Sep 17 00:00:00 2001 From: chegoryu Date: Mon, 1 Dec 2025 19:24:44 +0100 Subject: [PATCH 1/2] Fix *_write_page_index and size_statiscits comments Defaults were changed in this commit https://github.com/apache/arrow/commit/1fcc89240db4fe0ad798498e7410668423846118 --- cpp/src/parquet/properties.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/cpp/src/parquet/properties.h b/cpp/src/parquet/properties.h index 1dcfe67c29f3..0ce97f227c86 100644 --- a/cpp/src/parquet/properties.h +++ b/cpp/src/parquet/properties.h @@ -700,7 +700,7 @@ class PARQUET_EXPORT WriterProperties { return this; } - /// Enable writing page index in general for all columns. Default disabled. + /// Enable writing page index in general for all columns. Default enabled. /// /// Writing statistics to the page index disables the old method of writing /// statistics to each data page header. @@ -715,35 +715,35 @@ class PARQUET_EXPORT WriterProperties { return this; } - /// Disable writing page index in general for all columns. Default disabled. + /// Disable writing page index in general for all columns. Default enabled. Builder* disable_write_page_index() { default_column_properties_.set_page_index_enabled(false); return this; } - /// Enable writing page index for column specified by `path`. Default disabled. + /// Enable writing page index for column specified by `path`. Default enabled. Builder* enable_write_page_index(const std::string& path) { page_index_enabled_[path] = true; return this; } - /// Enable writing page index for column specified by `path`. Default disabled. + /// Enable writing page index for column specified by `path`. Default enabled. Builder* enable_write_page_index(const std::shared_ptr& path) { return this->enable_write_page_index(path->ToDotString()); } - /// Disable writing page index for column specified by `path`. Default disabled. + /// Disable writing page index for column specified by `path`. Default enabled. Builder* disable_write_page_index(const std::string& path) { page_index_enabled_[path] = false; return this; } - /// Disable writing page index for column specified by `path`. Default disabled. + /// Disable writing page index for column specified by `path`. Default enabled. Builder* disable_write_page_index(const std::shared_ptr& path) { return this->disable_write_page_index(path->ToDotString()); } - /// \brief Set the level to write size statistics for all columns. Default is None. + /// \brief Set the level to write size statistics for all columns. Default is PageAndColumnChunk. /// /// \param level The level to write size statistics. Note that if page index is not /// enabled, page level size statistics will not be written even if the level From 9338be6900244c3f7800b9111d2272a885bb7311 Mon Sep 17 00:00:00 2001 From: Egor Chunaev Date: Tue, 2 Dec 2025 10:55:07 +0100 Subject: [PATCH 2/2] fix --- cpp/src/parquet/properties.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cpp/src/parquet/properties.h b/cpp/src/parquet/properties.h index 0ce97f227c86..eb5aee29695e 100644 --- a/cpp/src/parquet/properties.h +++ b/cpp/src/parquet/properties.h @@ -743,7 +743,8 @@ class PARQUET_EXPORT WriterProperties { return this->disable_write_page_index(path->ToDotString()); } - /// \brief Set the level to write size statistics for all columns. Default is PageAndColumnChunk. + /// \brief Set the level to write size statistics for all columns. Default is + /// PageAndColumnChunk. /// /// \param level The level to write size statistics. Note that if page index is not /// enabled, page level size statistics will not be written even if the level