Skip to content

Commit f758d02

Browse files
authored
fix(transport): remove the hard dep on faraday-retry (#42)
Since we moved away for relying only on Faraday to support multiple HTTP transport, we shouldn't require this anymore. If someone wants to build a Faraday-based transport with a retry logic; they can implement their own custom transport.
1 parent d4be922 commit f758d02

3 files changed

Lines changed: 0 additions & 9 deletions

File tree

‎Gemfile.lock‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@ GEM
2525
logger
2626
faraday-net_http (3.4.2)
2727
net-http (~> 0.5)
28-
faraday-retry (2.4.0)
29-
faraday (~> 2.0)
3028
http-2 (1.1.3)
3129
httpx (1.7.3)
3230
http-2 (>= 1.1.3)
@@ -144,8 +142,6 @@ DEPENDENCIES
144142
altertable!
145143
base64
146144
faraday (~> 2.0)
147-
faraday-net_http
148-
faraday-retry
149145
httpx
150146
rake (~> 13.0)
151147
rbs

‎altertable.gemspec‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,5 @@ Gem::Specification.new do |spec|
3737

3838
# Optional adapter support (development only)
3939
spec.add_development_dependency "faraday", "~> 2.0"
40-
spec.add_development_dependency "faraday-retry"
41-
spec.add_development_dependency "faraday-net_http"
4240
spec.add_development_dependency "httpx"
4341
end

‎lib/altertable/adapters.rb‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,10 @@ class FaradayAdapter < Base
1818
def initialize(base_url:, timeout:, headers: {})
1919
super
2020
require "faraday"
21-
require "faraday/retry"
22-
require "faraday/net_http"
2321

2422
@conn = Faraday.new(url: @base_url) do |f|
2523
@headers.each { |k, v| f.headers[k] = v }
2624
f.options.timeout = @timeout
27-
f.request :retry, max: 3, interval: 0.05, backoff_factor: 2
2825
f.adapter Faraday.default_adapter
2926
end
3027
end

0 commit comments

Comments
 (0)