Process optimize#2359
Open
WRPStephanie wants to merge 23 commits into
Open
Conversation
Add MemCollector UnitTest
Fix the unittest.
Collaborator
|
百炼自动化审查:建议保持开启。 本 PR 包含进程与网卡采集器的有效缺陷修复(如指针 sizeof 误用、网卡缓存内存泄漏),但同时也引入了未说明的破坏性变更(注释掉进程核心指标字段 name/user/path/args)及错误处理语义变更(getpwuid_r 失败返回 true)。此外,本 PR 正文为空,提交历史混乱(23次提交含多次 merge),且基线较旧导致当前不可合并。. 最佳落地路径: 建议作者 Rebase 至最新 main 分支并解决冲突,将提交历史 Squash 为逻辑清晰的少量提交。补充 PR 正文详细说明移除进程基础信息字段的动机、getpwuid_r/getgrgid_r 失败时返回值变更的合理性及测试验证结果。维护者需重点审查破坏性变更对下游监控大盘的影响,确认无误后通过 CI 并合并。. 已核对内容:
百炼审查备注:模型 qwen3.6-max-preview;对照提交 30ac854deafd。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.