fix(organization): describe the budget's running-deployment switch as funding, not top-ups (#4552)

Users never see top-ups as a concept, since Console funds running deployments
from the balance on its own. The budget dialog, the project panel and the alert
email now say running deployments stay funded or stop being funded at the budget.

Author: baktun14

apps/api/src/notifications/services/notification-templates/project-budget-alert-notification.spec.ts

@@ -14,14 +14,14 @@ describe(projectBudgetAlertNotification.name, () => {
     expect(result.payload.summary).toBe("Project staging has committed 85% of its monthly budget");
     expect(result.payload.description).toBe(
       "Deposits committed for <strong>staging</strong> this month total <strong>$85.50</strong> of its <strong>$100.00</strong> monthly budget. " +
-        "New deployments in this project are refused once a deposit would go past the budget. Its running deployments keep being topped up. " +
+        "New deployments in this project are refused once a deposit would go past the budget. Its running deployments keep being funded. " +
         "An owner or admin can change the budget."
     );
     expect(result.payload.actions).toEqual([{ label: "View project", url: "https://console.akash.network/projects/project-1" }]);
     expect(result.user).toEqual({ id: "user-123", email: "user@example.com" });
   });
 
-  it("names the deposit that was not signed and says running deployments stop being topped up when that was chosen", () => {
+  it("names the deposit that was not signed and says running deployments stop being funded when that was chosen", () => {
     const user = createUser({ id: "user-123" });
 
     const result = projectBudgetAlertNotification(user, createVars({ committedUsd: 40, budgetUsd: 100, refusedUsd: 70, stopTopUps: true }));
@@ -30,8 +30,8 @@ describe(projectBudgetAlertNotification.name, () => {
     expect(result.payload.description).toContain(
       "monthly budget. A deposit of <strong>$70.00</strong> was not signed because it would have gone past the budget. New deployments"
     );
-    expect(result.payload.description).toContain("Top-ups of its running deployments stop at the budget too.");
-    expect(result.payload.description).not.toContain("keep being topped up");
+    expect(result.payload.description).toContain("Its running deployments stop being funded at the budget too.");
+    expect(result.payload.description).not.toContain("keep being funded");
   });
 
   it("escapes the project name in the markup and keeps it plain in the summary, which the email layout escapes", () => {

apps/api/src/notifications/services/notification-templates/project-budget-alert-notification.ts

@@ -20,7 +20,7 @@ export function projectBudgetAlertNotification(user: UserOutput, vars: ProjectBu
   const percent = Math.floor((vars.committedUsd * 100) / vars.budgetUsd);
   const refusal =
     vars.refusedUsd > 0 ? ` A deposit of <strong>${formatter.format(vars.refusedUsd)}</strong> was not signed because it would have gone past the budget.` : "";
-  const runningDeployments = vars.stopTopUps ? "Top-ups of its running deployments stop at the budget too." : "Its running deployments keep being topped up.";
+  const runningDeployments = vars.stopTopUps ? "Its running deployments stop being funded at the budget too." : "Its running deployments keep being funded.";
 
   return {
     notificationId: `projectBudgetAlert.${vars.projectId}.${vars.period}.${user.id}`,

apps/deploy-web/src/components/projects/ProjectBudgetDialog/ProjectBudgetDialog.spec.tsx

@@ -10,7 +10,7 @@ import { render, screen } from "@testing-library/react";
 import userEvent from "@testing-library/user-event";
 
 describe(ProjectBudgetDialog.name, () => {
-  it("sets a first budget with the default alert threshold and top-ups left running", async () => {
+  it("sets a first budget with the default alert threshold and running deployments left funded", async () => {
     const { createBudget, onClose, enqueueSnackbar } = setup({ budget: null });
 
     await userEvent.type(screen.getByLabelText("Monthly budget (USD)"), "750.5");
@@ -29,21 +29,21 @@ describe(ProjectBudgetDialog.name, () => {
     expect(screen.getByRole("heading", { name: "Set a monthly budget" })).toBeInTheDocument();
     expect(screen.getByText(/New deployments in storefront are refused once this month's deposits would pass the budget/)).toBeInTheDocument();
     expect(screen.getByText(/doesn't set money aside for the project or cap what running deployments use/)).toBeInTheDocument();
-    expect(screen.getByText(/Running deployments can then run out of funds and close\. Off by default\./)).toBeInTheDocument();
+    expect(screen.getByText(/Running deployments in this project normally stay funded past the budget/)).toBeInTheDocument();
     expect(screen.queryByRole("button", { name: "Remove budget" })).not.toBeInTheDocument();
   });
 
-  it("edits the existing budget, opting into stopping top-ups", async () => {
+  it("edits the existing budget, opting into cutting off running deployments", async () => {
     const { updateBudget, createBudget } = setup({ budget: budget() });
 
     expect(screen.getByRole("heading", { name: "Edit monthly budget" })).toBeInTheDocument();
     expect(screen.getByLabelText("Monthly budget (USD)")).toHaveValue("500");
     expect(screen.getByLabelText("Alert threshold (%)")).toHaveValue("90");
-    expect(screen.getByRole("switch", { name: "Stop top-ups when over budget" })).not.toBeChecked();
+    expect(screen.getByRole("switch", { name: "Stop funding running deployments at the budget" })).not.toBeChecked();
 
     await userEvent.clear(screen.getByLabelText("Alert threshold (%)"));
     await userEvent.type(screen.getByLabelText("Alert threshold (%)"), "75");
-    await userEvent.click(screen.getByRole("switch", { name: "Stop top-ups when over budget" }));
+    await userEvent.click(screen.getByRole("switch", { name: "Stop funding running deployments at the budget" }));
     await userEvent.click(screen.getByRole("button", { name: "Save budget" }));
 
     expect(updateBudget).toHaveBeenCalledWith({ id: "budget-1", data: { monthlyAmountUsd: 500, alertThresholdPercent: 75, stopTopUps: true } });

apps/deploy-web/src/components/projects/ProjectBudgetDialog/ProjectBudgetDialog.tsx

@@ -165,11 +165,11 @@ export function ProjectBudgetDialog({ projectId, projectName, budget, onClose, d
             <div className="flex items-start justify-between gap-4 rounded-lg border border-border px-3.5 py-3">
               <div className="space-y-1">
                 <Label htmlFor={stopTopUpsId} className="text-[13px]">
-                  Stop top-ups when over budget
+                  Stop funding running deployments at the budget
                 </Label>
                 <p id={`${stopTopUpsId}-hint`} className="text-xs text-muted-foreground">
-                  Also refuse manual and automatic top-ups of this project&apos;s running deployments that would pass the budget. Running deployments can then
-                  run out of funds and close. Off by default.
+                  Running deployments in this project normally stay funded past the budget. Turn this on to cut them off at the budget too, so they can run out
+                  of funds and close.
                 </p>
               </div>
               <Switch id={stopTopUpsId} checked={stopTopUps} aria-describedby={`${stopTopUpsId}-hint`} onCheckedChange={setStopTopUps} />

apps/deploy-web/src/components/projects/ProjectBudgetPanel/ProjectBudgetPanel.spec.tsx

@@ -107,16 +107,16 @@ describe(ProjectBudgetPanel.name, () => {
     expect(screen.queryByRole("status")).not.toBeInTheDocument();
   });
 
-  it("says whether top-ups stop at the budget", () => {
+  it("says when running deployments stop being funded at the budget", () => {
     setup({ budget: budget({ stopTopUps: true }) });
 
-    expect(screen.getByText("Top-ups stop at the budget.")).toBeInTheDocument();
+    expect(screen.getByText("Running deployments stop being funded at the budget.")).toBeInTheDocument();
   });
 
-  it("says top-ups continue past the budget by default", () => {
+  it("says running deployments stay funded past the budget by default", () => {
     setup({ budget: budget({ stopTopUps: false }) });
 
-    expect(screen.getByText("Top-ups continue past the budget.")).toBeInTheDocument();
+    expect(screen.getByText("Running deployments stay funded past the budget.")).toBeInTheDocument();
   });
 
   it("lets an owner set a budget for a project without one", async () => {
@@ -170,7 +170,7 @@ describe(ProjectBudgetPanel.name, () => {
     expect(screen.getByText("$9.00")).toBeInTheDocument();
     expect(screen.queryByText(/monthly budget/)).not.toBeInTheDocument();
     expect(screen.queryByRole("progressbar")).not.toBeInTheDocument();
-    expect(screen.queryByText(/Top-ups/)).not.toBeInTheDocument();
+    expect(screen.queryByText(/^Running deployments/)).not.toBeInTheDocument();
   });
 
   it("does not mistake another member's admin grant for the caller's", () => {
@@ -198,25 +198,25 @@ describe(ProjectBudgetPanel.name, () => {
 
     expect(
       screen.getByText(
-        "A budget limits new deposits into this project each month and doesn't set money aside. Running deployments keep their funding unless top-ups stop at the budget."
+        "A budget limits new deposits into this project each month and doesn't set money aside. Running deployments keep their funding unless the budget is set to cut them off."
       )
     ).toBeInTheDocument();
   });
 
-  it("warns that running deployments can run out of funds once top-ups stop at the budget", () => {
+  it("warns that running deployments can run out of funds once they stop being funded at the budget", () => {
     setup({ budget: budget({ stopTopUps: true }) });
 
     expect(
       screen.getByText(
-        "A budget limits new deposits into this project each month and doesn't set money aside. Top-ups stop at the budget, so running deployments can run out of funds and close."
+        "A budget limits new deposits into this project each month and doesn't set money aside. Running deployments stop being funded at the budget too, so they can run out of funds and close."
       )
     ).toBeInTheDocument();
   });
 
   it("keeps the default footnote for a project without a budget", () => {
     setup({ budget: null });
 
-    expect(screen.getByText(/Running deployments keep their funding unless top-ups stop at the budget\./)).toBeInTheDocument();
+    expect(screen.getByText(/Running deployments keep their funding unless the budget is set to cut them off\./)).toBeInTheDocument();
   });
 
   function setup(input: {

apps/deploy-web/src/components/projects/ProjectBudgetPanel/ProjectBudgetPanel.tsx

@@ -74,8 +74,8 @@ export function ProjectBudgetPanel({ projectId, projectName, dependencies: d = D
         <p className="border-t border-border bg-muted/40 px-4 py-2.5 text-xs text-muted-foreground">
           A budget limits new deposits into this project each month and doesn&apos;t set money aside.{" "}
           {budget?.stopTopUps
-            ? "Top-ups stop at the budget, so running deployments can run out of funds and close."
-            : "Running deployments keep their funding unless top-ups stop at the budget."}
+            ? "Running deployments stop being funded at the budget too, so they can run out of funds and close."
+            : "Running deployments keep their funding unless the budget is set to cut them off."}
         </p>
       </div>
 
@@ -142,7 +142,9 @@ function BudgetSettings({ budget, canManage, onEdit }: { budget: ProjectBudget |
 
   return (
     <div className="flex items-center justify-between gap-3 border-t border-border px-4 py-3">
-      <span className="text-xs text-muted-foreground">{budget.stopTopUps ? "Top-ups stop at the budget." : "Top-ups continue past the budget."}</span>
+      <span className="text-xs text-muted-foreground">
+        {budget.stopTopUps ? "Running deployments stop being funded at the budget." : "Running deployments stay funded past the budget."}
+      </span>
       {canManage && (
         <Button variant="outline" size="sm" className="text-xs" onClick={onEdit}>
           Edit budget